Merge pull request #685 from Satellite-im/luis/fixes-test-mac

screenobject(update): fix tests failing on CI for accessibility
Satellite-im · Apr 29, 2024 · e58c598 · e58c598
2 parents 0fde0d6 + 6c60c63
commit e58c598
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/tests/helpers/commandsNewUser.ts b/tests/helpers/commandsNewUser.ts
@@ -7,7 +7,6 @@ import SettingsProfileScreen from "@screenobjects/settings/SettingsProfileScreen
 import WelcomeScreen from "@screenobjects/welcome-screen/WelcomeScreen";
 import {
   activateFirstApplication,
-  activateSecondApplication,
   getUserKey,
   launchSecondApplication,
   launchThirdApplication,

diff --git a/tests/screenobjects/settings/SettingsBaseScreen.ts b/tests/screenobjects/settings/SettingsBaseScreen.ts
@@ -64,7 +64,7 @@ export default class SettingsBaseScreen extends UplinkMainScreen {
   }
 
   public get accessibilityButton() {
-    return $(SELECTORS.ACCESSIBILITY_BUTTON);
+    return this.settingsLayout.$(SELECTORS.ACCESSIBILITY_BUTTON);
   }
 
   public get audioButton() {
@@ -108,7 +108,7 @@ export default class SettingsBaseScreen extends UplinkMainScreen {
   }
 
   public get settingsSearchInput() {
-    return $(SELECTORS.SETTINGS_SEARCH_INPUT);
+    return this.settingsLayout.$(SELECTORS.SETTINGS_SEARCH_INPUT);
   }
 
   async goToAboutSettings() {

diff --git a/tests/specs/10-settings-accessibility.spec.ts b/tests/specs/10-settings-accessibility.spec.ts
@@ -27,17 +27,15 @@ export default async function settingsAccessibilityTests() {
     );
   });
 
-  // Skip test that needs rework because it is clicking on a switch slider from MacOS configuration instead of Uplink - Settings Accessibility Screen
-  xit("Settings Accessibility - Click on slider switch to enable Open Dyslexic option", async () => {
+  it("Settings Accessibility - Click on slider switch to enable Open Dyslexic option", async () => {
     // Click on the Open Dyslexic switch slider from the Settings Accessibility Screen
     await SettingsAccessibilityScreen.clickOnOpenDyslexic();
 
     // Validate that toggle has now value = "1" (enabled)
     await SettingsAccessibilityScreen.validateOpenDyslexicIsEnabled();
   });
 
-  // Skip test that needs rework because it is clicking on a switch slider from MacOS configuration instead of Uplink - Settings Accessibility Screen
-  xit("Settings Audio - Click on slider switches to disable the options", async () => {
+  it("Settings Audio - Click on slider switches to disable the options", async () => {
     // Click again on the switch slider from Open Dyslexic option in Settings Accessibility Screen
     await SettingsAccessibilityScreen.clickOnOpenDyslexic();