Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove async sig from {FileDocument, MessageDocument}::new #657

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

dariusc93
Copy link
Contributor

What this PR does 📖

  • remove async signature from FileDocument::new and MessageDocument::new.
  • Remove Result from FileDocument::new

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@dariusc93 dariusc93 self-assigned this Dec 28, 2024
@dariusc93 dariusc93 changed the title refactor: remove async sig from {FileDocument, MessageDocument)::new refactor: remove async sig from {FileDocument, MessageDocument}::new Dec 28, 2024
@dariusc93 dariusc93 marked this pull request as ready for review December 28, 2024 21:20
@dariusc93 dariusc93 merged commit 37bb6e3 into main Dec 28, 2024
3 checks passed
@dariusc93 dariusc93 deleted the refactor/remove-async-sig-filedocument branch December 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant