Skip to content

upgrade safe-wipe and fix a few typos #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade safe-wipe and fix a few typos #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { foo } from './foo';

## Module exports

Exported functions and classes should always have a name, even if it's not required per see. Naming exports help debugging and figuring out what's going on.
Exported functions and classes should always have a name, even if it's not required per se. Naming exports helps debugging and figuring out what's going on.

```js
export default function foo() {}
Expand Down Expand Up @@ -104,7 +104,7 @@ Same goes with do/while and try/catch.

## Inline documentation

Every function should be documented using [JSDoc](http://usejsdoc.org/). Annotations should not be aligned in order not to have to update alignment whever a longer line is added.
Every function should be documented using [JSDoc](http://usejsdoc.org/). Annotations should not be aligned in order not to have to update alignment whenever a longer line is added.

```js
/**
Expand All @@ -116,7 +116,7 @@ Every function should be documented using [JSDoc](http://usejsdoc.org/). Annotat

## Comments

All comments, both inline and multiline should be written in proper English, starting with a cap, ending with a full stop. Inline comments (`//`) are used when the comment holds on a single line (<80 characters). Multiline C-style comments (`/** */`) are used when the comment is splitted across several lines.
All comments, both inline and multiline should be written in proper English, starting with a cap, ending with a full stop. Inline comments (`//`) are used when the comment holds on a single line (<80 characters). Multiline C-style comments (`/** */`) are used when the comment is split across several lines.

```js
// Post process configuration.
Expand All @@ -126,7 +126,7 @@ config.view = config; // Backward compatibility.

/**
* This is an extra long comment that does not fit on a single line because it
* is longer than 80 characters. Because of this, it it splitted across several
* is longer than 80 characters. Because of this, it is split across several
* lines.
*/
```
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"mkdirp": "^1.0.4",
"multipipe": "1.0.2",
"rimraf": "^3.0.2",
"safe-wipe": "0.2.5",
"safe-wipe": "0.3.0",
"sass-convert": "^0.5.0",
"sassdoc-theme-default": "^2.8.3",
"scss-comment-parser": "^0.8.4",
Expand Down
49 changes: 31 additions & 18 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2401,7 +2401,7 @@ fs-readdir-recursive@^1.0.0:
fs.realpath@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f"
integrity sha1-FQStJSMVjKpA20onh8sBQRmU6k8=
integrity sha512-OO0pH2lK6a0hZnAdau5ItzHPI6pUlvI7jMVnxUQRtw4owF2wk8lOSabtGDCTP4Ggrg2MbGnWO9X8K1t4+fGMDw==

fsevents@^1.0.0:
version "1.1.2"
Expand Down Expand Up @@ -2585,7 +2585,19 @@ glob@^7.0.0, glob@^7.0.3, glob@^7.1.2:
once "^1.3.0"
path-is-absolute "^1.0.0"

glob@^7.0.5, glob@^7.0.6, glob@^7.1.3:
glob@^7.0.5:
version "7.2.3"
resolved "https://registry.yarnpkg.com/glob/-/glob-7.2.3.tgz#b8df0fb802bbfa8e89bd1d938b4e16578ed44f2b"
integrity sha512-nFR0zLpU2YCaRxwoCJvL6UvCH2JFyFVIvwTLsIf21AuHlMskA1hhTdk+LlYJtOlYt9v6dvszD2BGRqBL+iQK9Q==
dependencies:
fs.realpath "^1.0.0"
inflight "^1.0.4"
inherits "2"
minimatch "^3.1.1"
once "^1.3.0"
path-is-absolute "^1.0.0"

glob@^7.0.6, glob@^7.1.3:
version "7.1.4"
resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.4.tgz#aa608a2f6c577ad357e1ae5a5c26d9a8d1969255"
integrity sha512-hkLPepehmnKk41pUGm3sYxoFs/umurYfYJCerbXEyFIWcAzvpipAgVkBqqT9RBKMGjnq6kMuyYwha6csxbiM1A==
Expand Down Expand Up @@ -2895,7 +2907,7 @@ indent-string@^2.1.0:
inflight@^1.0.4:
version "1.0.6"
resolved "https://registry.yarnpkg.com/inflight/-/inflight-1.0.6.tgz#49bd6331d7d02d0c09bc910a1075ba8165b56df9"
integrity sha1-Sb1jMdfQLQwJvJEKEHW6gWW1bfk=
integrity sha512-k92I/b08q4wvFscXCLvqfsHCrjrF7yiXsQuIVvVE7N82W3+aqpzuUdBbfhWcy/FZR3/4IgflMgKLOsvPDrGCJA==
dependencies:
once "^1.3.0"
wrappy "1"
Expand Down Expand Up @@ -4038,6 +4050,13 @@ minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.3, minimatch@^3.0.4:
dependencies:
brace-expansion "^1.1.7"

minimatch@^3.1.1:
version "3.1.2"
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.1.2.tgz#19cd194bfd3e428f049a70817c038d89ab4be35b"
integrity sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==
dependencies:
brace-expansion "^1.1.7"

[email protected]:
version "0.0.8"
resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d"
Expand Down Expand Up @@ -4432,7 +4451,7 @@ object.pick@^1.3.0:
once@^1.3.0, once@^1.3.1, once@^1.3.2, once@^1.3.3, once@^1.4.0:
version "1.4.0"
resolved "https://registry.yarnpkg.com/once/-/once-1.4.0.tgz#583b1aa775961d4b113ac17d9c50baef9dd76bd1"
integrity sha1-WDsap3WWHUsROsF9nFC6753Xa9E=
integrity sha512-lNaJgI+2Q5URQBkccEKHTQOPaXdUxnZZElQTZY0MFUAuaEqe1E+Nyvgdz/aIyNi6Z9MzO5dv1H8n58/GELp3+w==
dependencies:
wrappy "1"

Expand Down Expand Up @@ -4618,7 +4637,7 @@ path-exists@^3.0.0:
path-is-absolute@^1.0.0, path-is-absolute@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/path-is-absolute/-/path-is-absolute-1.0.1.tgz#174b9268735534ffbc7ace6bf53a5a9e1b5c5f5f"
integrity sha1-F0uSaHNVNP+8es5r9TpanhtcX18=
integrity sha512-AVbw3UJ2e9bq64vSaS9Am0fje1Pa8pbGqTTsmXfaIiMpnr5DlDhfJOuLj9Sf95ZPVDAUerDfEk88MPmPe7UCQg==

path-is-inside@^1.0.1:
version "1.0.2"
Expand Down Expand Up @@ -4811,11 +4830,6 @@ pupa@^2.0.1:
dependencies:
escape-goat "^2.0.0"

q@1.*:
version "1.5.0"
resolved "https://registry.yarnpkg.com/q/-/q-1.5.0.tgz#dd01bac9d06d30e6f219aecb8253ee9ebdc308f1"
integrity sha1-3QG6ydBtMObyGa7LglPunr3DCPE=

qs@~6.4.0:
version "6.4.0"
resolved "https://registry.yarnpkg.com/qs/-/qs-6.4.0.tgz#13e26d28ad6b0ffaa91312cd3bf708ed351e7233"
Expand Down Expand Up @@ -5216,14 +5230,14 @@ ret@~0.1.10:
resolved "https://registry.yarnpkg.com/ret/-/ret-0.1.15.tgz#b8a4825d5bdb1fc3f6f53c2bc33f81388681c7bc"
integrity sha512-TTlYpa+OL+vMMNG24xSlQGEJ3B/RzEfUlLct7b5G/ytav+wPrplCpVMFuwzXbkecJrb6IYo1iFb0S9v37754mg==

rimraf@2, rimraf@2.*, rimraf@^2.2.8, rimraf@^2.5.1:
rimraf@2, rimraf@^2.2.8, rimraf@^2.5.1:
version "2.6.1"
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.1.tgz#c2338ec643df7a1b7fe5c54fa86f57428a55f33d"
integrity sha1-wjOOxkPfeht/5cVPqG9XQopV8z0=
dependencies:
glob "^7.0.5"

rimraf@^2.6.1, rimraf@^2.6.2:
rimraf@2.*, rimraf@^2.6.1, rimraf@^2.6.2:
version "2.7.1"
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec"
integrity sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w==
Expand Down Expand Up @@ -5281,13 +5295,12 @@ safe-regex@^1.1.0:
dependencies:
ret "~0.1.10"

safe-wipe@0.2.5:
version "0.2.5"
resolved "https://registry.yarnpkg.com/safe-wipe/-/safe-wipe-0.2.5.tgz#dbb331be98d32fee660372999ee5d1ae89ab2fdd"
integrity sha512-MwTNf4YrRqCHsB5jUzOVdXoRbW4jkhgTvhlyfiaxox8EP7cOCiD4ydMOQCxDPR9KpvwdBSM2dQHScV1m85k8wQ==
safe-wipe@0.3.0:
version "0.3.0"
resolved "https://registry.yarnpkg.com/safe-wipe/-/safe-wipe-0.3.0.tgz#b33b1f7db27b8e7bc943f36427dfd7f940a816a7"
integrity sha512-d/RbqoJREVAjY1kChYq+iZtnWt4Heg85AppfhXaEelcZchDZ2oMPcfISbXPDOnsUkwdv5s03iiycAMEWQySf+Q==
dependencies:
extend "^3.0.2"
q "1.*"
rimraf "2.*"

"safer-buffer@>= 2.1.2 < 3":
Expand Down Expand Up @@ -6360,7 +6373,7 @@ wrap-ansi@^2.0.0:
wrappy@1:
version "1.0.2"
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f"
integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=
integrity sha512-l4Sp/DRseor9wL6EvV2+TuQn63dMkPjZ/sp9XkghTEbV9KlPS1xUsZ3u7/IQO4wxtcFB4bgpQPRcR3QCvezPcQ==

write-file-atomic@^1.1.4:
version "1.3.4"
Expand Down