fix(theme): remove orphaned dark-mode stylesheet + Settings toggle#203
Conversation
|
Warning Review limit reached
More reviews will be available in 52 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
frontend | c93aa1a | Commit Preview URL Branch Preview URL |
Jun 12 2026, 04:58 AM |
c228af1 to
e670ae1
Compare
The app is light-mode only, but a full html.dark token block in globals.css and a 'dark' option in the Settings Theme select both remained as dead code. Nothing applied the .dark class, so the dark option was a latent regression. Remove both; dark mode gets its own branch if it ships later. Closes #105
e670ae1 to
c93aa1a
Compare
What
Removes dead dark-mode code from the light-mode-only app:
html.dark { … }token block (andhtml.dark input/select/textareacolor-schemerules) fromfrontend/src/app/globals.css."dark"option from the Theme selector infrontend/src/components/screens/Settings.tsx(Theme now offers only"light").Why
The project is light-mode only, and
globals.cssitself notes that dark mode "gets its own branch — not squatting in the same stylesheet." Nothing ever applied the.darkclass (Settings only sets--accentinline), so the token block was dead CSS and the"dark"Theme option was a latent regression that could one wire away activate an off-spec theme with glowing chrome.How verified
npx tsc --noEmit— clean (exit 0).npx vitest run— 37 passed (5 files), exit 0.html.dark/.dark/color-scheme: dark/prefers-color-schemeinfrontend/src. Thesettings.themefield is retained (still valid, now light-only) and is never used to toggle a dark class.--accent-glowremains only in the in-spec.landing-pageblock, untouched.Closes #105