Skip to content

fix(theme): remove orphaned dark-mode stylesheet + Settings toggle#203

Merged
Jose-Gael-Cruz-Lopez merged 1 commit into
mainfrom
fix/remove-dead-dark-mode
Jun 12, 2026
Merged

fix(theme): remove orphaned dark-mode stylesheet + Settings toggle#203
Jose-Gael-Cruz-Lopez merged 1 commit into
mainfrom
fix/remove-dead-dark-mode

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

What

Removes dead dark-mode code from the light-mode-only app:

  • Deletes the html.dark { … } token block (and html.dark input/select/textarea color-scheme rules) from frontend/src/app/globals.css.
  • Removes the "dark" option from the Theme selector in frontend/src/components/screens/Settings.tsx (Theme now offers only "light").

Why

The project is light-mode only, and globals.css itself notes that dark mode "gets its own branch — not squatting in the same stylesheet." Nothing ever applied the .dark class (Settings only sets --accent inline), so the token block was dead CSS and the "dark" Theme option was a latent regression that could one wire away activate an off-spec theme with glowing chrome.

How verified

  • npx tsc --noEmit — clean (exit 0).
  • npx vitest run — 37 passed (5 files), exit 0.
  • Grep confirms no remaining references to html.dark / .dark / color-scheme: dark / prefers-color-scheme in frontend/src. The settings.theme field is retained (still valid, now light-only) and is never used to toggle a dark class. --accent-glow remains only in the in-spec .landing-page block, untouched.

Closes #105

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 52 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0bc5d2eb-8125-4b58-adf2-6c606e586dc7

📥 Commits

Reviewing files that changed from the base of the PR and between 824d7e4 and c93aa1a.

📒 Files selected for processing (2)
  • frontend/src/app/globals.css
  • frontend/src/components/screens/Settings.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-dead-dark-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
frontend c93aa1a Commit Preview URL

Branch Preview URL
Jun 12 2026, 04:58 AM

@Jose-Gael-Cruz-Lopez Jose-Gael-Cruz-Lopez force-pushed the fix/remove-dead-dark-mode branch from c228af1 to e670ae1 Compare June 12, 2026 01:17
The app is light-mode only, but a full html.dark token block in
globals.css and a 'dark' option in the Settings Theme select both
remained as dead code. Nothing applied the .dark class, so the dark
option was a latent regression. Remove both; dark mode gets its own
branch if it ships later.

Closes #105
@Jose-Gael-Cruz-Lopez Jose-Gael-Cruz-Lopez force-pushed the fix/remove-dead-dark-mode branch from e670ae1 to c93aa1a Compare June 12, 2026 04:46
@Jose-Gael-Cruz-Lopez Jose-Gael-Cruz-Lopez merged commit b45cafc into main Jun 12, 2026
5 checks passed
@Jose-Gael-Cruz-Lopez Jose-Gael-Cruz-Lopez deleted the fix/remove-dead-dark-mode branch June 12, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Remove orphaned dark-mode stylesheet + Settings toggle

1 participant