feat: add reward pool balance validation before hunt activation#568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds reward pool balance validation before hunt activation. When a reward manager is configured,
activate_huntnow verifies that the pool balance is sufficient to covermin_distribution_amount * max_winnersbefore allowing the hunt to be activated.Acceptance Criteria
Changes
contracts/reward-manager/src/lib.rs
get_min_distribution_amountpublic getter that returns themin_distribution_amountfrom the pool config (or 0 if no pool exists)contracts/hunty-core/src/lib.rs
activate_huntto query the reward manager formin_distribution_amountvia cross-contract callpool_balance >= min_distribution_amount * max_winners(usingsaturating_mulfor overflow safety)HuntErrorCode::InsufficientRewardPoolwith detailed error info when validation failsmin_distribution_amount > 0(0 = no minimum constraint)Testing
cargo build -p reward-manager && cargo build -p hunty-corecargo test -p hunty-core && cargo test -p reward-managerCloses #360