Fix numeric coercion for property update expressions #187
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a semantic mismatch in how property modify-and-assign operations are handled compared to the JavaScript specification.
When performing an increment operation on an object property whose value is not already numeric, the required coercion is not applied. As a result, operations such as obj.foo++ can produce behavior that diverges from standard JavaScript semantics.
This PR fixes the issue by propagating numeric context information through the modify-and-assign instrumentation and applying ToNumber coercion at runtime. A unit test has been added to capture this edge case and prevent regressions.
Example Demonstrating the Issue
This issue can be reproduced independently of analysis.js: