requests: fix small ui bugs

* closes CERNDocumentServer/cds-rdm#176
Samk13 · Jul 30, 2024 · bb785b1 · bb785b1
1 parent 78ada9f
commit bb785b1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 19 deletions.
diff --git a/...pp_rdm/requests_ui/templates/semantic-ui/invenio_requests/community-submission/index.html b/...pp_rdm/requests_ui/templates/semantic-ui/invenio_requests/community-submission/index.html
@@ -37,23 +37,22 @@
     class="ui container rdm-tab-container fluid rel-pt-2 ml-0-mobile mr-0-mobile"
     id="request-community-submission-tab-container"
   >
-    {% if record %}
-      <div
-        class="ui secondary pointing menu rdm-tab-menu"
-        id="request-community-submission-tab"
+    <div
+      class="ui secondary pointing menu rdm-tab-menu"
+      id="request-community-submission-tab"
+    >
+      <a
+        class="active item"
+        data-tab="conversation"
+        role="tab"
+        aria-selected="true"
+        aria-controls="conversation-tab-panel"
+        id="conversation-tab"
       >
-        <a
-          class="active item"
-          data-tab="conversation"
-          role="tab"
-          aria-selected="true"
-          aria-controls="conversation-tab-panel"
-          id="conversation-tab"
-        >
-          {{ _("Conversation") }}
-        </a>
-
+        {{ _("Conversation") }}
+      </a>
 
+      {% if record %}
         <a
           role="tab"
           class="item"
@@ -64,9 +63,8 @@
         >
           {{ _("Record") }}
         </a>
-      </div>
-    {% endif %}
-
+      {% endif %}
+    </div>
 
     <div
       class="ui bottom attached tab segment active borderless p-0"

diff --git a/invenio_app_rdm/requests_ui/views/requests.py b/invenio_app_rdm/requests_ui/views/requests.py
@@ -49,7 +49,7 @@ def _resolve_topic_record(request):
     user_owns_request = str(creator_id) == str(current_user.id)
 
     if request["is_closed"] and not user_owns_request:
-        return dict(permissions={}, record_ui=None)
+        return dict(permissions={}, record_ui=None, record=None)
 
     record = None
     # parse the topic field to get the draft/record pid `record:abcd-efgh`