share-modal: account for system created records

Samk13 · Aug 23, 2024 · 880a126 · 880a126
1 parent 1b5cf91
commit 880a126
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/...ic-ui/js/invenio_app_rdm/landing_page/ShareOptions/AccessUsersGroups/AccessUsersGroups.js b/...ic-ui/js/invenio_app_rdm/landing_page/ShareOptions/AccessUsersGroups/AccessUsersGroups.js
@@ -91,7 +91,7 @@ export class AccessUsersGroups extends Component {
                   </Table.Row>
                 </Table.Header>
                 <Table.Body>
-                  {searchType === "user" && (
+                  {searchType === "user" && recOwner && (
                     <Table.Row>
                       <Table.Cell width={8}>
                         <Grid textAlign="left" verticalAlign="middle">

diff --git a/...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/ShareModal.js b/...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/ShareOptions/ShareModal.js
@@ -89,25 +89,21 @@ export class ShareModal extends Component {
     const { handleClose, groupsEnabled } = this.props;
     const { linksResults, groupsResults, usersResults } = this.state;
 
-    const users = [];
-    const groups = [];
+    let numUsers = 0;
+    let numGroups = 0;
     record.parent?.access?.grants?.forEach((grant) => {
-      if (grant.subject.type === "user") users.push(grant);
-      if (grant.subject.type === "role") groups.push(grant);
-    });
-
-    const links = [];
-    record.parent?.access?.links?.forEach((link) => {
-      if (link.id !== null) links.push(link);
+      if (grant.subject.type === "user") numUsers++;
+      if (grant.subject.type === "role") numGroups++;
     });
+    if (record?.expanded?.parent?.access?.owned_by) numUsers++;
 
     const panes = [
       {
         menuItem: (
           <MenuItem key="accessUsers">
             <Icon name="user" />
             {i18next.t("People")}
-            <Label size="tiny">{users?.length + 1}</Label>
+            <Label size="tiny">{numUsers}</Label>
           </MenuItem>
         ),
         render: () => (
@@ -122,13 +118,14 @@ export class ShareModal extends Component {
         ),
       },
     ];
+
     if (groupsEnabled) {
       panes.push({
         menuItem: (
           <MenuItem key="accessGroups">
             <Icon name="users" />
             {i18next.t("Groups")}
-            <Label size="tiny">{groups?.length}</Label>
+            <Label size="tiny">{numGroups}</Label>
           </MenuItem>
         ),
         render: () => (
@@ -144,13 +141,18 @@ export class ShareModal extends Component {
       });
     }
 
+    let numLinks = 0;
+    record.parent?.access?.links?.forEach((link) => {
+      if (link.id !== null) numLinks++;
+    });
+
     panes.push(
       {
         menuItem: (
           <MenuItem key="accessLinks">
             <Icon name="linkify" />
             {i18next.t("Links")}
-            <Label size="tiny">{links?.length}</Label>
+            <Label size="tiny">{numLinks}</Label>
           </MenuItem>
         ),
         render: () => (