feat: Added fromatting for Credit Card Number - #139
Merged
Samarth2190 merged 3 commits intoOct 28, 2025
Conversation
Samarth2190
approved these changes
Oct 28, 2025
Samarth2190
left a comment
Samarth2190
left a comment
Owner
There was a problem hiding this comment.
Issue fixed. Merging request.
|
|
||
| | Parameter | Type | Default | Description | | ||
| | ---------- | ------ | -------- | ------------------------------------------------------------------- | | ||
| | cardNumber | string | required | The credit card number to format. Can include non-digit characters. | |
Owner
There was a problem hiding this comment.
Suggested change
| | cardNumber | string | required | The credit card number to format. Can include non-digit characters. | | |
| | cardNumber | string | required | The credit card number to format. Cannot include non-digit characters. | |
I think it should be "Cannot include non-digit characters." as credit card number is digit only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
Closes issue #114
Changes