feat: add --check-stale flag for CI gating (fixes #2) - #64
Open
Fuhua-GIF wants to merge 1 commit into
Open
Conversation
- Add --check-stale flag: exits 1 if stale diagnostic artifacts exist - Add --max-stale-bytes option (default: 0 = any stale is error) - Add find_stale_artifacts() and check_stale_artifacts() functions - Add 5 self-tests (--self-test flag) - Add documentation in docs/OPERATIONS.md - Read-only: does not delete artifacts All 5 self-tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--check-staleflag tobuild.pyfor CI pipeline gating, as requested in #2.Changes
Updated
build.py:--check-staleCLI flag: exits 1 if older (non-current-commit) diagnostic artifacts exist--max-stale-bytesoption (default: 0 = any stale is an error)find_stale_artifacts()function: scansdiagnostic/for artifacts from other commitscheck_stale_artifacts()function: compares artifact commit IDs to current HEAD--self-test) covering empty dir, current artifacts, stale detection, byte thresholds, and chunked artifactsUpdated
docs/OPERATIONS.md:--check-staleUsage
Testing
All 5 self-tests pass:
Diagnostic Artifacts
Diagnostic JSON metadata: build-ec966bc5.json
Note: .logd file could not be generated on Windows (encryptly binary not available for this platform). JSON metadata is included.
Checklist
--check-staleflag added to build.py--max-stale-bytesoption worksdocs/OPERATIONS.mdFixes #2