Add collection of Scala methods and classes#19
Open
boyanbonev wants to merge 2 commits intoSagacify:masterfrom
Open
Add collection of Scala methods and classes#19boyanbonev wants to merge 2 commits intoSagacify:masterfrom
boyanbonev wants to merge 2 commits intoSagacify:masterfrom
Conversation
boyanbonev
force-pushed
the
master
branch
2 times, most recently
from
fbf2ac7 to
c6274ef
Compare
There was no support for collecting Scala class number so I added it. Tested with the unit tests and with SonarQube 6.3.1. Everything seemed OK.
The count of the Scala methods was missing so I added support for this. Tested with unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed Sonar to be able to collect Scala classes and method and that's why I extended the code in a way that the author intended.
Btw I count both "object" and "class" for classes.
I run several test on my local SonarQube and both of the methods worked OK.