Upgrade Winston from 2.x to 3.x #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorgowing
approved these changes
Aug 23, 2021
|
@trevorgowing FYI, I think that rebasing was the wrong choice here. The history is now guaranteed to diverge from the Jembi repo. A fast-forward merge would have been a better choice since it would have kept the exact same commit hash, which would then match the commit that gets merged into the Jembi repo. We'll just have to force push and overwrite this repo's master branch with the upstream one if/when that PR gets merged. |
|
@bausmeier Noted. My bad. I didn't even think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened an upstream PR (jembi#195), but also opening one here so that we don't have to wait for a response.