Merged
Conversation
Dev-lemongrab
approved these changes
Oct 3, 2025
Contributor
Dev-lemongrab
left a comment
Dev-lemongrab
left a comment
There was a problem hiding this comment.
기획내용 잘 반영된것 같습니다. 알림쪽 후처리 넣을라고 했는데 대신 작업해주셔서 감사합니다.
몇가지 코멘트 달아주신 거 확인 해주시면 감사하겠습니다!
고생하셨습니다!
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.stream.Collectors; | ||
| import java.util.Optional; |
Contributor
There was a problem hiding this comment.
import optional
빼도될거 같습니다!
| Map<Long, PollChoiceVoteInfo> mostVotedPollChoiceByPostId = getMostVotedPollChoiceByPostId(postIds); | ||
|
|
||
| List<MyPagePostResponse> response = getMyPagePostResponses(userId, postSlice, mostVotedPollChoiceByPostId); | ||
|
|
Contributor
There was a problem hiding this comment.
이부분 리스트라 다른 명명규칙 썼던 것처럼 복수로 하는게 좋을거 같습니다!
그리고, getMyPagePostResponses에서 필터에 걸러지면 postSlice hasNext랑 달라지는 현상이 생기진 않을까요?
Contributor
Author
There was a problem hiding this comment.
오 그 부분은 생각 못했는데 감사합니다! 수정했습니다
| import static com.chooz.support.fixture.PostFixture.SELF_CREATE_OPTION; | ||
| import static com.chooz.support.fixture.PostFixture.createDefaultPost; | ||
| import static com.chooz.support.fixture.PostFixture.createPostBuilder; | ||
| import static org.assertj.core.api.Assertions.*; |
Contributor
There was a problem hiding this comment.
와일드카드 표현이랑 안쓰는 임포트문정리 하면 좋을거 같습니다.
Contributor
Author
|
코멘트 남겨주신 부분 수정해서 다시 올렸습니다 |
Contributor
넵 확인했습니다~! 고생하셨습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 작업 내용 설명
📢 그 외
📌 관련 이슈