gitlint: Allow trivial changes to be without reference (SOC-9559) #3518
Conversation
scripts/jenkins/gitlint.ini
Outdated
| @@ -8,13 +8,10 @@ line-length=80 | |||
| words=wip,WIP | |||
|
|
|||
| [title-match-regex] | |||
| regex=^(?!SOC).*\(((bsc#|SOC-)[0-9]+(,\s)?)+\)$ | |||
| regex=^(?!SOC).*\((((bsc#|SOC-)[0-9]+(,\s)?)+|trivial)\)$ | |||
There was a problem hiding this comment.
is there corresponding filtering on "(trivial)" in the changelog extraction code? because I think we shouldn't have this in customer visible changelogs..
There was a problem hiding this comment.
Why not? We could use a different word if this is what you want to say.
|
@rsalevsky maybe there should be more keywords included like "typo", "spelling", etc. EDIT: example which would fall into this category: crowbar/crowbar-core#1873 |
rsalevsky
force-pushed
the
gitlint2
branch
2 times, most recently
from
4fcc035
to
db96f0a
Compare
|
Added:
|
|
@rsalevsky now you can fix the typo in your commit title :oD (refer[e]nce) |
The author of a commit should make a conscious decision to either add a reference or not. Adding trivial instead of bsc or SOC enables this. This change prevents that adding a refernce is forgotten as the syntax requires to think about it. trivial -> simple unplanned changes noref -> more complex unplanned changes typo -> typo fixes only See SUSE-Cloud#3509 (comment) for more details.
This check prevented external contributions.
rsalevsky
changed the title
|
@rsalevsky I really think this is to some extend the responsibility of a reviewer as well to check for references. if references are forgotten - its not the end of the world, they can be added to the .changes file afterwards as well. |
The author of a commit should make a conscious decision to either add a
reference or not. Adding trivial instead of bsc or SOC enables this.
This change prevents that adding a refernce is forgotten as the
syntax requires to think about it.
See #3509 for more details.