mkcloud: improve image cache usage #3428
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prevent the image cache directory to fill up the disk the cache should share its images with all jobs. A 'per' job cache does not make sense for an image thats just used once. So the value of $cache_dir_default is now a shared directory and no longer contains the cloud name. To not break running deployments rsync needs to drop the 'inplace' parameter, so that it first syncs the new image and then does a rename at the end. This guarantees that 1) there is always one consistent image to deploy from, 2) no running jobs read from currupt files, 3) the cache really caches for all jobs on the host. The compress parameter can also be dropped because the image files are already compressed. So we can save CPU cycles.
jdsn
force-pushed
the
better-cache-handling
branch
from
3562f8b
to
9e622d3
Compare
bmwiedemann
approved these changes
May 14, 2019
dirkmueller
requested changes
May 14, 2019
|
Thanks for the hint, will rework the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent the image cache directory to fill up
the disk the cache should share its images with all jobs.
A 'per' job cache does not make sense for an image thats
just used once.
So the value of $cache_dir_default is now a shared directory
and no longer contains the cloud name.
To not break running deployments rsync needs to drop the
'inplace' parameter, so that it first syncs the new image
and then does a rename at the end.
This guarantees that