Skip to content

improvement/parameter-dependency-on-every-iteration#71

Draft
dmark04 wants to merge 11 commits intomainfrom
70-dependency-not-implemented-in-each-generation
Draft

improvement/parameter-dependency-on-every-iteration#71
dmark04 wants to merge 11 commits intomainfrom
70-dependency-not-implemented-in-each-generation

Conversation

@dmark04
Copy link
Copy Markdown
Collaborator

@dmark04 dmark04 commented Feb 28, 2024

The goal here is to enable parameters to depend an each other and keep this dependency through every iteration of an optimization process.

There are multiple ways to implement this I think.

Currently the way things work can be summarized as follows:

  1. user specifies experiment
  2. based on experiment datapoints are created (here the dependency is already used)
  3. the optimization takes those datapoints and in each iteration generates new points
  4. these points are written to the experiment
  5. repeat steps 3&4 until done.

Importantly in step 3/4 the dependency is not used as we do not go back all the way to the Parameter object where this dependency is implemented.
For our blackbox optimization algorithms we can certainly add some step in between before we write things into the experiment/ to the algorithm.
Also, changing constraints at different steps of the optimization might not be supported by all algorithms.

@dmark04 dmark04 linked an issue Feb 28, 2024 that may be closed by this pull request
@dmark04 dmark04 marked this pull request as draft February 28, 2024 10:53
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8141572881

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 93.891%

Files with Coverage Reduction New Missed Lines %
yotse/utils/prediction.py 1 0.0%
Totals Coverage Status
Change from base Build 7944078701: -0.08%
Covered Lines: 1122
Relevant Lines: 1195

💛 - Coveralls

dependabot bot and others added 8 commits March 1, 2024 17:46
Bumps [pre-commit/action](https://github.com/pre-commit/action) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [JRubics/poetry-publish](https://github.com/jrubics/poetry-publish) from 1.17 to 2.0.
- [Release notes](https://github.com/jrubics/poetry-publish/releases)
- [Commits](JRubics/poetry-publish@v1.17...v2.0)

---
updated-dependencies:
- dependency-name: JRubics/poetry-publish
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…nto 70-dependency-not-implemented-in-each-generation
…mmit/action-3.0.1' into 70-dependency-not-implemented-in-each-generation
@dmark04
Copy link
Copy Markdown
Collaborator Author

dmark04 commented Apr 8, 2024

Features now fully implemented. Found a few errors that were previously not checked and are causing some tests and examples to fail now. Fix in next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency not implemented in each generation

2 participants