Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7625: changed heading level for a11y order #385

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Mar 17, 2025

READY FOR REVIEW

Summary

  • Fixing the order of the h3 and h4

Review By (Date)

  • for v5.6.0

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to an event page with a schedule of events
  4. Verify the heading structure matches what is in the ticket

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7625

Resources

Sorry, something went wrong.

@jenbreese jenbreese changed the title D8CORE-7625: changed heading level for best order D8CORE-7625: changed heading level for a11y order Mar 18, 2025
@jenbreese jenbreese requested a review from pookmish March 18, 2025 00:48
@pookmish pookmish merged commit ed376a9 into 9.x Mar 21, 2025
6 of 9 checks passed
@pookmish pookmish deleted the D8CORE-7625--event-schedule branch March 21, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants