Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-7661: Filtered List Paragraph #894

Merged

Conversation

buttonwillowsix
Copy link
Contributor

@buttonwillowsix buttonwillowsix commented Mar 24, 2025

READY FOR REVIEW

Summary

  • Filtered list paragraph for Opportunities filtered views

Review By (Date)

  • 5.6.0 code freeze

Criticality

  • Critical!

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Make sure D8CORE-7661 Filtered Lists stanford_profile_helper#386 is merged
  2. Check out this branch
  3. Create a 1-col layout
  4. Select this filtered list PT as a paragraph
  5. Select the opportunities view
  6. Enjoy!

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? YES

Front End Validation

Backend / Functional Validation

Code

  • [YES ] Are the naming conventions following our standards?
  • [YES ] Does the code have sufficient inline comments?
  • [ NO] Is there anything in this code that would be hidden or hard to discover through the UI?
  • [NO ] Are there any code smells?
  • [ NO] Are tests provided? eg (unit, behat, or codeception)

General

  • [NO ] Is there anything included in this PR that is not related to the problem it is trying to solve?
  • [Hopefully ] Is the approach to the problem appropriate?

Affected Projects or Products

  • Opportunities
  • 5.6.0

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@github-actions github-actions bot added size/s and removed size/xs labels Mar 24, 2025
@jenbreese
Copy link
Contributor

Hi @buttonwillowsix I would like more instructions on what I'm testing. I do not see a new paragraph option. I notice now the PR says not ready but a ticket asked me to look. Just let me know.

@github-actions github-actions bot added the patch label Mar 28, 2025
Copy link
Contributor

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@jenbreese jenbreese merged commit 91b27ec into feature/D8CORE-5741--opportunities Mar 28, 2025
4 of 7 checks passed
@jenbreese jenbreese deleted the D8CORE-7661-filtered-lists-ftw branch March 28, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants