added the notion of router hierarchy

[MarkNijhof]

Now all routers are automatically added to a list and enabled the use of this.navigate('../other_route') which then takes the parent route to execute navigate on. Not tested but this should also enable this.navigate('../../other/route'). Works as well with [Link href="../other_route"]home[/Link]

[MarkNijhof]

I found a small bug, will fix tonight and add to this PR

[STRML]

This is simple. I like it. Could you add some tests and squash the commits?

[MarkNijhof]

I'll see how I can test this and will squash them when I have some tests. make test-local doesn't run for me. Do you depends on specific browsers? I am on Ubuntu with only Chrome

[STRML]

make test-local should work if you npm install beforehand and make sure that port 3000 is unused on your machine. If you're still having problems, could you tell me what 'doesn't work' means?

[MarkNijhof]

Ok that was simple, I had something running on port 3000 ;-) so what do you recommend creating some browser based tests to verify this functionality or unit tests

[STRML]

Yeah, I would put it in browser.js - the other files are more specific. I would put it around the section where it starts testing contextual routers.

On Sep 16, 2014, at 4:54 PM, Mark Nijhof [email protected] wrote:

Ok that was simple, I had something running on port 3000 ;-) so what do you recommend creating some browser based tests to verify this functionality or unit tests

—
Reply to this email directly or view it on GitHub.

[MarkNijhof]

Ok I added 6 tests 3 for history and 3 for hash api with contextual routers. I am having trouble rebasing the commits as there have been updates from master that I had applied as well in the middle of them. Any hints on how to do this properly?

[MarkNijhof]

I'll fix this differently :) new PR coming up

[STRML]

Yeah the thing to do would be to rebase your branch on master - git rebase master should do it.

[MarkNijhof]

I added #84 sorry for any confusion