Surface sampling segfaults when LB is turned on#11
Closed
FoamScience wants to merge 8 commits intov2212from
Closed
Surface sampling segfaults when LB is turned on#11FoamScience wants to merge 8 commits intov2212from
FoamScience wants to merge 8 commits intov2212from
Conversation
FoamScience
changed the title
Collaborator
Author
|
#29 took over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in reference to #10
So far unable to reliably reproduce on the damrBreak2D case. so this PR tracks work on this issue.
From the logs provided with #10 it seems the load balancer
segfaults right after the logic that computes the new imbalance (which would be the logic that "redistributes" the mesh).
Tested on the following combinations:
ATM; it seems sampling classes don't like excessive boundary changes; probably caching some internal lists, which get outdated with LB ops.
All the errors I got are from:
Foam::sampledPatch::sampleOnFaceswith some reference to interpolation functions, so it's worth testing out different surface sampling ways...