Skip to content

chore: point strategies and probes at oracle.t0trade.com - #48

Open
Siddharth2207 wants to merge 11 commits into
mainfrom
chore/point-all-strategies-at-oracle-t0trade
Open

chore: point strategies and probes at oracle.t0trade.com#48
Siddharth2207 wants to merge 11 commits into
mainfrom
chore/point-all-strategies-at-oracle-t0trade

Conversation

@Siddharth2207

@Siddharth2207 Siddharth2207 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Point every strategy / probe / smoke oracle-url at https://oracle.t0trade.com/... (v1–v4 paths preserved).
  • Update fixed-spread v4 oracle-signer to production signer 0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84 so signed context verifies after the cutover.
  • Bump strategy/registry pins to the strategy commits.

Notes

Test plan

  • Diff confirms all oracle-url values use oracle.t0trade.com
  • Diff confirms fixed-spread v4 scenarios use signer 0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84
  • Confirm strategy/registry pins match the strategy commits on this branch
  • Spot-check one v4 quote against oracle.t0trade.com with the new signer after merge/deploy

Summary by CodeRabbit

  • Updates

    • Updated local examples, strategies, and production configurations to use the new oracle service URLs across versions 1–4.
    • Updated trusted oracle signer settings for supported strategies.
    • Refreshed strategy registry references to newer pinned resources.
    • Updated production smoke tests to target the new oracle endpoint.
  • Documentation

    • Updated example commands and configuration guidance with the current production oracle URLs.
  • Bug Fixes

    • Shortened select validation error messages without changing validation behavior.

Siddharth2207 and others added 2 commits July 22, 2026 21:07
Replace the Fly.dev oracle hostname with the production
oracle.t0trade.com URLs across all strategy versions and local/prod
probe helpers.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 131d8fe0-acb6-48cb-8f60-2f5a5193dc01

📥 Commits

Reviewing files that changed from the base of the PR and between b757866 and 83f51d3.

📒 Files selected for processing (4)
  • strategy/registry
  • strategy/st0x-oracle-limit-v3.rain
  • strategy/st0x-oracle-limit-v4.rain
  • strategy/st0x-oracle-limit.rain
🚧 Files skipped from review as they are similar to previous changes (1)
  • strategy/registry

📝 Walkthrough

Walkthrough

The PR updates v1–v4 oracle endpoints and signer settings, refreshes strategy registry commit pins, shortens selected v4 revert messages, and updates probe documentation and the production smoke-test endpoint.

Changes

Oracle endpoint migration

Layer / File(s) Summary
Strategy oracle endpoints and validation updates
strategy/st0x-oracle-limit*.rain
Strategy configurations use versioned oracle.t0trade.com endpoints and new trusted signer addresses. Selected v4 validation revert messages are shorter.
Strategy registry reference update
strategy/registry
Raw GitHub references for strategy settings and oracle-limit artifacts are pinned to commit 36a23db7f03cf25c8c56240dcb9022b3d4ec791d.
Probe and smoke endpoint references
examples/probe_local*.rs, tests/smoke_prod.rs
Probe documentation and the production smoke test use the corresponding oracle.t0trade.com endpoints.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: hardyjosh, juanirios

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: updating strategies and probes to use oracle.t0trade.com.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/point-all-strategies-at-oracle-t0trade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Siddharth2207
Siddharth2207 requested a review from hardyjosh July 22, 2026 15:42
Siddharth2207 and others added 2 commits July 23, 2026 21:23
Match production signer 0xE2f3…C7ec84 so context signatures verify after the oracle.t0trade.com cutover.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
strategy/st0x-oracle-limit-v4.rain (1)

6-20: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Synchronize the v4 trusted signer with the migrated endpoint.

strategy/st0x-oracle-limit-v4.rain now points to /context/v4, but its Base scenario still trusts 0x8Ff1CA8ED2e98f693A3eA16b3EBE44FE90500A43 while the other v4 scenarios trust 0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84. If the v4 endpoint rotated its signer, limit-v4 quotes will fail on the signer check; update this binding or document why the endpoint intentionally uses two signers.

Proposed fix
-      oracle-signer: 0x8Ff1CA8ED2e98f693A3eA16b3EBE44FE90500A43
+      oracle-signer: 0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@strategy/st0x-oracle-limit-v4.rain` around lines 6 - 20, Update the
oracle-signer binding in the base scenario of st0x-oracle-limit-v4 to use the
migrated v4 endpoint’s trusted signer, matching the other v4 scenarios. Keep the
oracle-schema-version and remaining bindings unchanged.

Source: MCP tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@strategy/st0x-oracle-limit-v4.rain`:
- Around line 6-20: Update the oracle-signer binding in the base scenario of
st0x-oracle-limit-v4 to use the migrated v4 endpoint’s trusted signer, matching
the other v4 scenarios. Keep the oracle-schema-version and remaining bindings
unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: db6ecd20-e69f-4fd2-85a5-ba8301d5cb38

📥 Commits

Reviewing files that changed from the base of the PR and between 0e1645f and bfa8fb5.

📒 Files selected for processing (11)
  • examples/probe_local.rs
  • examples/probe_local_v2.rs
  • examples/probe_local_v3.rs
  • strategy/registry
  • strategy/st0x-fixed-spread-v3.rain
  • strategy/st0x-fixed-spread-v4.rain
  • strategy/st0x-fixed-spread.rain
  • strategy/st0x-oracle-limit-v3.rain
  • strategy/st0x-oracle-limit-v4.rain
  • strategy/st0x-oracle-limit.rain
  • tests/smoke_prod.rs

Siddharth2207 and others added 4 commits July 24, 2026 13:35
Rain StringTooLong rejects literals over 31 bytes; "Oracle price before
session start" is 33. Also shorten oracle-limit v4 pair-mismatch messages.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve conflicts by keeping main's removal of fixed-spread strategies
(#51) while retaining the oracle.t0trade.com URL cutover for the
remaining limit strategies.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207
Siddharth2207 removed the request for review from hardyjosh July 27, 2026 15:51
Siddharth2207 and others added 2 commits August 6, 2026 17:47
Update v1/v3/v4 oracle-signer to 0xdB665B5ef8Bd04Fd977bB3A64790eaa52749ACcc
so signed context verifies against the current production key.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant