chore: point strategies and probes at oracle.t0trade.com - #48
chore: point strategies and probes at oracle.t0trade.com#48Siddharth2207 wants to merge 11 commits into
Conversation
Replace the Fly.dev oracle hostname with the production oracle.t0trade.com URLs across all strategy versions and local/prod probe helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates v1–v4 oracle endpoints and signer settings, refreshes strategy registry commit pins, shortens selected v4 revert messages, and updates probe documentation and the production smoke-test endpoint. ChangesOracle endpoint migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Match production signer 0xE2f3…C7ec84 so context signatures verify after the oracle.t0trade.com cutover. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
strategy/st0x-oracle-limit-v4.rain (1)
6-20: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSynchronize the v4 trusted signer with the migrated endpoint.
strategy/st0x-oracle-limit-v4.rainnow points to/context/v4, but its Base scenario still trusts0x8Ff1CA8ED2e98f693A3eA16b3EBE44FE90500A43while the other v4 scenarios trust0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84. If the v4 endpoint rotated its signer, limit-v4 quotes will fail on the signer check; update this binding or document why the endpoint intentionally uses two signers.Proposed fix
- oracle-signer: 0x8Ff1CA8ED2e98f693A3eA16b3EBE44FE90500A43 + oracle-signer: 0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@strategy/st0x-oracle-limit-v4.rain` around lines 6 - 20, Update the oracle-signer binding in the base scenario of st0x-oracle-limit-v4 to use the migrated v4 endpoint’s trusted signer, matching the other v4 scenarios. Keep the oracle-schema-version and remaining bindings unchanged.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@strategy/st0x-oracle-limit-v4.rain`:
- Around line 6-20: Update the oracle-signer binding in the base scenario of
st0x-oracle-limit-v4 to use the migrated v4 endpoint’s trusted signer, matching
the other v4 scenarios. Keep the oracle-schema-version and remaining bindings
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: db6ecd20-e69f-4fd2-85a5-ba8301d5cb38
📒 Files selected for processing (11)
examples/probe_local.rsexamples/probe_local_v2.rsexamples/probe_local_v3.rsstrategy/registrystrategy/st0x-fixed-spread-v3.rainstrategy/st0x-fixed-spread-v4.rainstrategy/st0x-fixed-spread.rainstrategy/st0x-oracle-limit-v3.rainstrategy/st0x-oracle-limit-v4.rainstrategy/st0x-oracle-limit.raintests/smoke_prod.rs
Rain StringTooLong rejects literals over 31 bytes; "Oracle price before session start" is 33. Also shorten oracle-limit v4 pair-mismatch messages. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve conflicts by keeping main's removal of fixed-spread strategies (#51) while retaining the oracle.t0trade.com URL cutover for the remaining limit strategies. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Update v1/v3/v4 oracle-signer to 0xdB665B5ef8Bd04Fd977bB3A64790eaa52749ACcc so signed context verifies against the current production key. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
oracle-urlathttps://oracle.t0trade.com/...(v1–v4 paths preserved).oracle-signerto production signer0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84so signed context verifies after the cutover.strategy/registrypins to the strategy commits.Notes
Test plan
oracle-urlvalues useoracle.t0trade.com0xE2f3e6aBde8D4dF23256B250Ae98dEe760C7ec84strategy/registrypins match the strategy commits on this branchoracle.t0trade.comwith the new signer after merge/deploySummary by CodeRabbit
Updates
Documentation
Bug Fixes