Turn dispatch from recursive to iterative #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
force-pushed
the
non-recursive-dispatch
branch
2 times, most recently
from
196bc04 to
4d20e89
Compare
smarr
force-pushed
the
non-recursive-dispatch
branch
4 times, most recently
from
4333ccc to
1b070e8
Compare
smarr
force-pushed
the
non-recursive-dispatch
branch
from
1b070e8 to
dc0b72f
Compare
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
This is only a partial solution, there are still cases where we do not have the correct holder. Signed-off-by: Stefan Marr <[email protected]>
…right parent) Also extract code to reduce duplication. Signed-off-by: Stefan Marr <[email protected]>
…when needed Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- also simplify the code to remove invalid node Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
non-recursive-dispatch
branch
from
dc0b72f to
a64fee0
Compare
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the dispatch chain's recursive walk with an iterative one.