[pull] main from millionco:main - #224
Merged
Merged
Conversation
#1658) * fix: prevent stack overflow in function resolution with depth limiting Add depth limiting to resolveExactLocalFunction to prevent infinite recursion when resolving function references through deeply nested expressions, TypeScript path aliases, or complex import chains. The function now enforces a configurable depth limit (FUNCTION_RESOLUTION_MAX_DEPTH = 15) and returns null when exhausted rather than continuing to recurse. - Add FUNCTION_RESOLUTION_MAX_DEPTH constant (15 levels) - Thread remainingDepth parameter through all resolution helpers - Add unit tests for depth limiting - Add regression test for zustand + Next.js + path aliases case Closes #1657 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test: exercise function resolution stack guard * refactor: share function chain fixture builder * test: tighten function resolution regressions --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden.bai05@gmail.com>
…e patterns (#1666) * fix: extract entry points from implicit sub-projects outside workspace patterns When the root package.json declares workspaces, sub-projects outside the declared workspace globs were discovered but their entry points (main, bin, exports) were skipped. This caused false positives in unused-file detection. The fix removes the isDeclaredWorkspace predicate from entry extraction - any package with a valid package.json should have its entry points extracted regardless of workspace pattern matching. Fixes #1665 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * chore: add changeset for issue #1665 fix Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test: consolidate implicit workspace entry regression * docs(changeset): clarify implicit entry fix --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden.bai05@gmail.com>
…obal-at-module-scope (#1668) * fix: ignore TypeScript type-only positions in no-unguarded-browser-global-at-module-scope The rule was incorrectly flagging browser-global names (window, navigator, etc.) when they appeared as property keys in TypeScript interfaces and type aliases. These are type-only positions that TypeScript erases during compilation, so no runtime reference error occurs. Add isTypeScriptTypePosition check to skip identifiers in TS type contexts before reporting. Add regression tests covering interface properties, type alias properties, and the preserved behavior for actual runtime references. Fixes #1667 Co-authored-by: Skosh <skoshx@users.noreply.github.com> * chore: add changeset for #1667 fix Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test: add edge case tests for TypeScript type positions Co-authored-by: Skosh <skoshx@users.noreply.github.com> * test: preserve type-only browser global regression * docs(changeset): clarify type-only global fix --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Skosh <skoshx@users.noreply.github.com> Co-authored-by: Aiden Bai <aiden.bai05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )