Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elasticsearch Version to 8.5.2 #1

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

aldidoanta
Copy link
Collaborator

@aldidoanta aldidoanta commented Dec 2, 2022

Overview

Known Issues

  • kibiter does not support ES 8. According to this statement about grimoirelab-kibiter, we cannot rely on Kibiter if we need to use ES 8. We need to use Kibana, and somehow adapt it to the existing grimoirelab ecosystem.
  • An error message related to enrichment.
grimoire_elk.elk - ERROR - [git] Problem executing study enrich_onion:git,
RequestError(400, 'x_content_parse_exception', '[1:74] [date_histogram] unknown field [interval] did you mean [fixed_interval]?')

- docker-compose references: https://github.com/deviantony/docker-elk
- TODO: update Kibana version, since the mappping type is not supported anymore
…`, revert `kibiter`, disable `panels` phase
This way, we can access all the required files without putting them in `/docker` or `/docker-compose` directory.
@aldidoanta aldidoanta requested review from Rafaeltheraven and BenWillemsen and removed request for Rafaeltheraven December 2, 2022 15:43
@TomG777
Copy link

TomG777 commented Dec 8, 2022

It seems you should be able to use

      build:
        context: ../docker
        dockerfile: Dockerfile

instead in the docker-compose.
That way you don't need to add the docker/ in front of the stage file in the Dockerfile.
This simplifies things and likely will work towards us breaking less things.

@aldidoanta
Copy link
Collaborator Author

aldidoanta commented Dec 9, 2022

It seems you should be able to use

      build:
        context: ../docker
        dockerfile: Dockerfile

instead in the docker-compose. That way you don't need to add the docker/ in front of the stage file in the Dockerfile. This simplifies things and likely will work towards us breaking less things.

@TomG777 I tried using that approach, and used this in Dockerfile

COPY ../requirements.txt ${CONF_DIR}/requirements.txt

But Docker complained that the requirements.txt is outside the build context

COPY failed: forbidden path outside the build context: ../requirements.txt ()

@aldidoanta
Copy link
Collaborator Author

aldidoanta commented Dec 9, 2022

Three possible workarounds:
a. Modify the build context in docker-compose.yml and the path to requirements.txt in Dockerfile. Basically what I'm doing in this PR. Or
b. Move requirements.txt into the docker/ directory. Or
c. Put docker-compose.yml and Dockerfile in the project root, and delete all the unused docker-compose files.

@aldidoanta
Copy link
Collaborator Author

Three possible workarounds:
a. Modify the build context in docker-compose.yml and the path to requirements.txt in Dockerfile. Basically what I'm doing in > this PR. Or
b. Move requirements.txt into the docker/ directory. Or
c. Put docker-compose.yml and Dockerfile in the project root, and delete all the unused docker-compose files.

@TomG777 Do you have any further comments about these possible workarounds? Otherwise I'll use my current approach.

@aldidoanta aldidoanta merged commit 2efe33a into master Dec 16, 2022
@aldidoanta aldidoanta deleted the chore/update-elasticsearch-version branch December 16, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants