Change the calling convention in sick_scan_xd_api_wrapper.c from __stdcall to __cdecl #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to issue #310
Changing the calling convention from __stdcall to __cdecl here enables the library to operate in 32-bit mode. Since the .dll is also compiled with __cdecl as the calling convention this makes sense.
However, we weren't able to test if the library still works fine with real hardware though.