Skip to content

addPosition implemented, changes to election Model#69

Open
BautistaBertolami wants to merge 3 commits into
masterfrom
addPosition
Open

addPosition implemented, changes to election Model#69
BautistaBertolami wants to merge 3 commits into
masterfrom
addPosition

Conversation

@BautistaBertolami
Copy link
Copy Markdown
Collaborator

@BautistaBertolami BautistaBertolami commented Nov 14, 2020

Fixes #45

Description

addPosition creates a Position object and stores it in the positions array of the election document. The election model's positions array was changed to use a object literal array instead of a Positions object array

(UPDATE)
The positions array is no longer a thing, addPositions now initializes a Position collection inside of our election document.
The elections collection has been renamed to election, and the singular election document should use "election" as it's ID.
Various function names were renamed from elections to election, e.g. closeElections is now closeElection

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist:

  • My code follows the code style of this project found on ESLint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BautistaBertolami
Copy link
Copy Markdown
Collaborator Author

Quick correction, the commit says event, that should say election. I keep getting the two names confused.

Comment thread functions/src/Services/Elections.ts Outdated
Comment thread functions/src/Services/Elections.ts Outdated
Comment thread functions/src/Services/Elections.ts Outdated
Copy link
Copy Markdown
Collaborator

@jeffjramos21 jeffjramos21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just implement the changes sofia brought up and I'll approve

Copy link
Copy Markdown
Collaborator

@jeffjramos21 jeffjramos21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

addPosition func

4 participants