addPosition implemented, changes to election Model#69
Open
BautistaBertolami wants to merge 3 commits into
Open
addPosition implemented, changes to election Model#69BautistaBertolami wants to merge 3 commits into
BautistaBertolami wants to merge 3 commits into
Conversation
Collaborator
Author
|
Quick correction, the commit says event, that should say election. I keep getting the two names confused. |
smontana30
approved these changes
Nov 14, 2020
Collaborator
jeffjramos21
left a comment
There was a problem hiding this comment.
looks good, just implement the changes sofia brought up and I'll approve
…icationsOpen is true
Sebastian1712
approved these changes
Nov 16, 2020
smontana30
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
Description
addPosition creates a Position object and stores it in the positions array of the election document. The election model's positions array was changed to use a object literal array instead of a Positions object array(UPDATE)
The positions array is no longer a thing, addPositions now initializes a Position collection inside of our election document.
The elections collection has been renamed to election, and the singular election document should use "election" as it's ID.
Various function names were renamed from elections to election, e.g. closeElections is now closeElection
Types of changes
Checklist: