Skip to content

Add Modal component#235

Open
idelmr wants to merge 14 commits into
masterfrom
modal
Open

Add Modal component#235
idelmr wants to merge 14 commits into
masterfrom
modal

Conversation

@idelmr
Copy link
Copy Markdown
Contributor

@idelmr idelmr commented Feb 15, 2021

Description

Add custom Modal component to:

  • Control zIndex (priority) of multiple modals: Higher (larger magnitude) priorities would render on top of lower priority modals or screens
  • Add onHide callback to hide Modal when the backdrop or the Android back button are pressed (also customizable with given props)
  • Give access to Modal inner styles to avoid unnecessary children styles

Missing: Animations (slide from middle, slide from bottom, and fade)

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist:

  • My code follows the code style of this project found on Contribution guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@idelmr idelmr linked an issue Feb 15, 2021 that may be closed by this pull request
Comment thread src/components/general/Modal.js Outdated
@idelmr idelmr force-pushed the master branch 2 times, most recently from 36a4580 to e6ae79f Compare April 5, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Modal (Overlay) Component Creation [iOS]

2 participants