Skip to content

fix issue #4003: Resolve issue with CompilationDatabase combined with variant_dir yielding incorrect output. #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #4003: Resolve issue with CompilationDatabase combined with variant_dir yielding incorrect output. #4722

wants to merge 1 commit into from

Conversation

edwardpeek-crown-public
Copy link

@edwardpeek-crown-public edwardpeek-crown-public commented May 21, 2025 •
edited
Loading

Fixes issue #4003.

Only do srcnode() mapping for files that are actually raw sources.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@mwichmann mwichmann moved this to In progress in Next Release May 21, 2025
@bdbaddog
Copy link
Contributor

Initial glance this looks good.
Can you also add a blurb in RELEASE.txt
I'll do a thorough review in the next couple days.

@edwardpeek-crown-public edwardpeek-crown-public force-pushed the issue_4003_comp_db_missing_variantdir_codegen branch from dd16593 to ac8f313 Compare May 23, 2025 02:12
@bdbaddog bdbaddog changed the title fix issue #4003 to emit variant dir for built sources fix issue #4003: Resolve issue with CompilationDatabase combined with variant_dir yielding incorrect output. May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compliation_db variantdir
Projects
Next Release
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardpeek-crown-public @bdbaddog @mwichmann