Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2772 Standardise the most convenient DataPoint selector #3069

Open
wants to merge 4 commits into
base: release/2.8.0
Choose a base branch
from

Conversation

Patrykb0802
Copy link
Contributor

Changed selector in data point edit view as well as in point links view and publisher edit view

Changed selector in data point edit view as well as in point links view and publisher edit view
Copy link

github-actions bot commented Dec 17, 2024

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   3s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f318cc3. ± Comparison against base commit 284961e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Java JUnit Test Results

2 720 tests  +351   2 720 ✅ +351   45s ⏱️ +3s
  118 suites +  4       0 💤 ±  0 
  118 files   +  4       0 ❌ ±  0 

Results for commit f318cc3. ± Comparison against base commit 284961e.

♻️ This comment has been updated with latest results.

@fabiodurao
Copy link

Hi Patrykb the data point selector also needs to be updated in:

  • Reports screen;
  • In the event handler of the "setpoint" type.

@Limraj Limraj added this to the 2.9.0 milestone Dec 18, 2024
@Limraj Limraj modified the milestones: 2.9.0, 2.8.0 Feb 3, 2025
Copy link
Collaborator

@Limraj Limraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saved:
image
Reload page then:
image
No saved -> error

@Limraj Limraj modified the milestones: 2.8.0, 2.9.0 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants