Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy G4 files, introduce standard fcl directory #809

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Mar 7, 2025

This PR does 3 things:

  1. removal of the legacy G4 fhicl files
  2. creating of a "standard" folder pointing to the standard production fhicl files
  3. centrally suppress warning messages from SimDriftElectrons, which currently overwhelm log files

Format of fcl files in the standard directory is:
standard_${data/mc}_${workflow}_${step}_icarus.fcl

@cerati cerati marked this pull request as ready for review March 14, 2025 13:38
@cerati cerati requested review from jzennamo and SFBayLaser March 27, 2025 16:47
Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't go through every file but I did not see any that were deleted that looked like a mistake.
One question: should we remove "refactored" from fcl names since that won't have meaning going forward?

@cerati
Copy link
Contributor Author

cerati commented Mar 27, 2025

eventually yes, but for now I would not do it to avoid breaking CI tests and current production configs. Once they all switch to the standard fcls it will be easier to rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants