fix: cache middleware now checks response status before storing (fixes #1197) - #11
Open
vaishnavi003-svg wants to merge 1 commit into
Open
fix: cache middleware now checks response status before storing (fixes #1197)#11vaishnavi003-svg wants to merge 1 commit into
vaishnavi003-svg wants to merge 1 commit into
Conversation
|
Thank you @, for creating the PR and contributing to our UltimateHealth project 💗. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
API cache was saving error responses (401, 403, 500) and serving them as valid data to users.
Fix
Added status code check before caching - now only success responses (200-299) are cached.
Changes
middleware/verifyToken.js- Added status validationmiddleware/cacheMiddleware.js- Only caches 2xx responsesapp.js- Updated middleware orderTest Results
Code Change