fix(OpenUI5Support): fix sap.m.Select inside a ui5-dialog #11939
+88
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stoev
reviewed
Jul 22, 2025
| change: function (oEvent) { | ||
| console.error("Selected item:", oEvent.getParameter("selectedItem").getText()); | ||
| } | ||
| }).placeAt("dilog1content"); |
There was a problem hiding this comment.
Is this a typo?
placeAt("dilog1content") > placeAt("dialog1content")
| @@ -81,6 +94,7 @@ | |||
| <ui5-button id="myButton">Open WebC Dialog</ui5-button> | |||
| </div> | |||
| <ui5-dialog id="dialog1" header-text="This is an WebC Dialog 1"> | |||
| <div id="dilog1content"></div> | |||
There was a problem hiding this comment.
Is this a typo?
"dilog1content" > "dialog1content"
| @@ -14,6 +16,24 @@ type OpenUI5Popup = { | |||
| } | |||
| }; | |||
|
|
|||
| // contains all OpenUI5 and Web Component popups that are currently opened | |||
There was a problem hiding this comment.
Alternatively, if you consider more descriptive:
Registry containing all currently opened OpenUI5 and Web Component popups.
alexandar-mitsev
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
there 4 focus related bugs, but are not caused by the change (I will report them separately)
- if you replace the select with combobox, pressing escape closes the full dialog and not only the combobox popover. Similar behaviour can be reproduced if combobox is in ui5 dialog
- if you have combobox in openui5 dialog, start writing so that the popover appears - change the focus with Tab - there is a console error
- if you use keyboard only to open all dialogs, esc does not close the openui5 dialog properly
- the select is directly opened when the dialog is opened
| patchPopup, | ||
| addOpenedPopup, | ||
| removeOpenedPopup, | ||
| getTopMostPopup, |
There was a problem hiding this comment.
you can also use the single word "topmost", which means exactly this. Although "top most" is not too wrong either.
vladitasev
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize all web components and OpenUI5 popups into a single array to ensure that focus is managed by the uppermost popup.
fixes #11933