introduce detect11 as default, deprecate detect9 #5556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrskindel-sap
changed the title
Contributor
Author
|
/it-go |
Contributor
Doesn't seem the integration test suite ran? |
Contributor
Author
https://github.com/SAP/jenkins-library/actions/runs/19462197069 |
Contributor
yeah, looks like it did, My bad. |
jitendk
reviewed
Nov 18, 2025
cmd/detectExecuteScan.go
Outdated
|
|
||
| downloadScript := func() error { | ||
| if config.UseDetect8 { | ||
| log.Entry().Warn("The useDetect8 option is deprecated") |
Contributor
There was a problem hiding this comment.
Please remove detect8 reference as it is no more supported.
piotrskindel-sap
force-pushed
the
piotr/1055_detect_11
branch
from
f67e539 to
ff4a9ef
Compare
|
Contributor
Author
|
/it-go |
kaplan-michael
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist