Skip to content

chore: Add default value of virtualFrameBuffer parameter equaltrue #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: Add default value of virtualFrameBuffer parameter equaltrue #5550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f24b64
chore: Add default value of virtualFrameBuffer parameter equaltrue
maxcask Nov 10, 2025
aca1832
update generated
Nov 10, 2025
2a5baa5
Update npmExecuteScripts calls to use virtualFrameBuffer
maxcask Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/npmExecuteScripts_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions integration/integration_npm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestNPMIntegrationRunScriptsWithOptions(t *testing.T) {
//workaround to use test script util it is possible to set workdir for Exec call
testScript := `#!/bin/sh
cd /test
/piperbin/piper npmExecuteScripts --runScripts=start --scriptOptions=--tag,tag1 >test-log-runScriptWithOptions.txt 2>&1
/piperbin/piper npmExecuteScripts --runScripts=start --virtualFrameBuffer=false --scriptOptions=--tag,tag1 >test-log-runScriptWithOptions.txt 2>&1
`
os.WriteFile(filepath.Join(tempDir, "runPiper.sh"), []byte(testScript), 0700)

Expand Down Expand Up @@ -89,7 +89,7 @@ func TestNPMIntegrationRegistrySetInFlags(t *testing.T) {
//workaround to use test script util it is possible to set workdir for Exec call
testScript := `#!/bin/sh
cd /test
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build --defaultNpmRegistry=https://foo.bar >test-log-registrySetInFlags.txt 2>&1
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build --virtualFrameBuffer=false --defaultNpmRegistry=https://foo.bar >test-log-registrySetInFlags.txt 2>&1
`
os.WriteFile(filepath.Join(tempDir, "runPiper.sh"), []byte(testScript), 0700)

Expand Down Expand Up @@ -140,7 +140,7 @@ func TestNPMIntegrationRegistrySetInNpmrc(t *testing.T) {
//workaround to use test script util it is possible to set workdir for Exec call
testScript := `#!/bin/sh
cd /test
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build >test-log-registrySetInNpmrc.txt 2>&1
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build --virtualFrameBuffer=false >test-log-registrySetInNpmrc.txt 2>&1
`
os.WriteFile(filepath.Join(tempDir, "runPiper.sh"), []byte(testScript), 0700)

Expand Down Expand Up @@ -191,7 +191,7 @@ func TestNPMIntegrationRegistryWithTwoModules(t *testing.T) {
//workaround to use test script util it is possible to set workdir for Exec call
testScript := `#!/bin/sh
cd /test
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build --defaultNpmRegistry=https://foo.bar >test-log-registryWithTwoModules.txt 2>&1
/piperbin/piper npmExecuteScripts --install --runScripts=ci-build --virtualFrameBuffer=false --defaultNpmRegistry=https://foo.bar >test-log-registryWithTwoModules.txt 2>&1
`
os.WriteFile(filepath.Join(tempDir, "runPiper.sh"), []byte(testScript), 0700)

Expand Down
1 change: 1 addition & 0 deletions resources/metadata/npmExecuteScripts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ spec:
- PARAMETERS
- STAGES
- STEPS
default: true
- name: scriptOptions
type: "[]string"
description: Options are passed to all runScripts calls separated by a '--'. './piper npmExecuteScripts --runScripts ci-e2e --scriptOptions '--tag1' will correspond to 'npm run ci-e2e -- --tag1'
Expand Down
Loading