Skip to content

Bug for S/4 readiness check psuedo comments #65

Closed

Description

@jelliottp

We are running S/4 readiness checks, and have some cases where psuedo comments are applied with the note number indicating usage is ok. The "align parameters and components" rule however is moving this comment from the correct location to incorrect location, like below:

CALL FUNCTION 'STANDARD_FUNCTION' "#EC CI_USAGE_OK[1234567]
    EXPORTING
      param1 = val1
CALL FUNCTION 'STANDARD_FUNCTION'
    "#EC CI_USAGE_OK[1234567]
    EXPORTING
      param1 = val1

Activity

  1. jmgrassau commented on Jun 19, 2023

    @jmgrassau
    Member

    Hi Josh,

    oh, that's no good! I think this cleanup rule does not distinguish pseudo-comments from "normal" comments at this point, but it definitely should – thanks for reporting this!

    Kind regards,
    Jörg-Michael

  2. self-assigned this
    on Jun 23, 2023
  3. jmgrassau commented on Jun 23, 2023

    @jmgrassau
    Member

    Hi Josh,

    thanks again – this should be fixed in the next release!

    Kind regards,
    Jörg-Michael

  4. jmgrassau commented on Jun 26, 2023

    @jmgrassau
    Member

    Hi Josh,

    version 1.4.1 was just released, fixing this!

    Kind regards,
    Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions