You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
very sorry for responding only now! Hm, yes, that's clearly not an improvement in this case. Unfortunately, there is no dedicated cleanup rule for SUBMIT (yet), so instead, "Align keywords with second word of first line" does what its name suggests.
You could, of course, move the first WITH to the next line to avoid the issue. However, interestingly, the keyword documentation puts everything right of the program name:
So, as long as there is no cleanup rule for SUBMIT, I'd suggest that I modify "Align keywords with second word of first line" a bit, so in case of a SUBMIT statement, a line that starts with the keyword "WITH" will be aligned with the (first) "WITH" in the previous line – that would allow for both layouts, but avoid the issue you reported.
Activity
jmgrassau commentedon Jul 1, 2025
Hi Marius,
very sorry for responding only now! Hm, yes, that's clearly not an improvement in this case. Unfortunately, there is no dedicated cleanup rule for SUBMIT (yet), so instead, "Align keywords with second word of first line" does what its name suggests.
You could, of course, move the first WITH to the next line to avoid the issue. However, interestingly, the keyword documentation puts everything right of the program name:
So, as long as there is no cleanup rule for SUBMIT, I'd suggest that I modify "Align keywords with second word of first line" a bit, so in case of a SUBMIT statement, a line that starts with the keyword "WITH" will be aligned with the (first) "WITH" in the previous line – that would allow for both layouts, but avoid the issue you reported.
Kind regards,
Jörg-Michael
mraht commentedon Jul 1, 2025
Hi Jörg-Michael, sounds very good to me! :)
jmgrassau commentedon Jul 1, 2025
Hi Marius,
that was a fast answer :-) Okay, then this is what things would look like, depending on the position of the first WITH:
Kind regards,
Jörg-Michael
fix AlignWithSecondWordRule for SUBMIT ... WITH (SAP#396)
fix AlignWithSecondWordRule for SUBMIT ... WITH (#396)
jmgrassau commentedon Jul 8, 2025
Hi Marius,
thanks again for this example – alignment of such cases should now be better with version 1.21.2!
Kind regards,
Jörg-Michael
mraht commentedon Jul 8, 2025
Hi Jörg-Michael, yes, this looks really good - many thanks! :)