Skip to content

Submit report: Indent parameters (WITH) #396

Closed

Description

@mraht

If you have the following submit statement abapCleaner doesn't indent the parameters (WITH statement) correctly.

Expected:

SUBMIT rsqiwkex WITH qname IN it_r_qname
                WITH dest  EQ iv_rfcdest
       AND RETURN.

Instead:

SUBMIT rsqiwkex WITH qname IN it_r_qname
       WITH dest  EQ iv_rfcdest
       AND RETURN.

Activity

  1. jmgrassau commented on Jul 1, 2025

    @jmgrassau
    Member

    Hi Marius,

    very sorry for responding only now! Hm, yes, that's clearly not an improvement in this case. Unfortunately, there is no dedicated cleanup rule for SUBMIT (yet), so instead, "Align keywords with second word of first line" does what its name suggests.

    You could, of course, move the first WITH to the next line to avoid the issue. However, interestingly, the keyword documentation puts everything right of the program name:

    Image

    So, as long as there is no cleanup rule for SUBMIT, I'd suggest that I modify "Align keywords with second word of first line" a bit, so in case of a SUBMIT statement, a line that starts with the keyword "WITH" will be aligned with the (first) "WITH" in the previous line – that would allow for both layouts, but avoid the issue you reported.

    Kind regards,
    Jörg-Michael

  2. self-assigned this
    on Jul 1, 2025
  3. mraht commented on Jul 1, 2025

    @mraht
    Author

    Hi Jörg-Michael, sounds very good to me! :)

  4. jmgrassau commented on Jul 1, 2025

    @jmgrassau
    Member

    Hi Marius,

    that was a fast answer :-) Okay, then this is what things would look like, depending on the position of the first WITH:

    Image

    Kind regards,
    Jörg-Michael

  5. jmgrassau commented on Jul 8, 2025

    @jmgrassau
    Member

    Hi Marius,

    thanks again for this example – alignment of such cases should now be better with version 1.21.2!

    Kind regards,
    Jörg-Michael

  6. mraht commented on Jul 8, 2025

    @mraht
    Author

    Hi Jörg-Michael, yes, this looks really good - many thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions