You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Alignment of comment when using enumerated PERFORM #363
this bug should be fixed with the next release. Comment lines after the colon or comma will now be moved above the unchained commands, assuming that they comment on the respective part of the chain:
thanks again for reporting this issue! I meanwhile enhanced the "stress test" (which systematically introduces comments, pragmas and colons into the ABAP cleaner test code and checks whether the cleanup rules can deal with them) and found two more cleanup rules in which this issue could have come up. All should now be fixed in version 1.19.3, which was just released!
Activity
jmgrassau commentedon Sep 25, 2024
Hi Raukze,
please check in menu Help / About whether you are using the current release of ABAP cleaner (version 19.2) – I think this issue was already resolved.
Kind regards,
Jörg-Michael
jmgrassau commentedon Sep 25, 2024
P.S.: No, wait, now I can reproduce it! Okay, that's a bug, of course.
jmgrassau commentedon Sep 28, 2024
Hi Raukze,
this bug should be fixed with the next release. Comment lines after the colon or comma will now be moved above the unchained commands, assuming that they comment on the respective part of the chain:
Kind regards,
Jörg-Michael
fix ChainRule for asterisk comments after colon (SAP#363)
fix NeedlessParenthesesRule for asterisk comments after colon (SAP#363)
fix ChainRule for asterisk comments after colon (#363)
fix NeedlessParenthesesRule for asterisk comments after colon (#363)
jmgrassau commentedon Sep 30, 2024
Hi Raukze,
thanks again for reporting this issue! I meanwhile enhanced the "stress test" (which systematically introduces comments, pragmas and colons into the ABAP cleaner test code and checks whether the cleanup rules can deal with them) and found two more cleanup rules in which this issue could have come up. All should now be fixed in version 1.19.3, which was just released!
Kind regards,
Jörg-Michael