Skip to content

Alignment of comment when using enumerated PERFORM #363

Closed

Description

@Raukze

I got a syntax error because the comment with leading * is not aligned at the beginning of a line.

FORM form USING  VALUE(pv_bool) TYPE abap_bool.
ENDFORM.
 
START-OF-SELECTION.
  PERFORM form USING:
* comment
       abap_true,
       abap_false.
FORM form USING VALUE(pv_bool) TYPE abap_bool.
ENDFORM.
 
START-OF-SELECTION.
  PERFORM form USING
       * comment
                     abap_true.
  PERFORM form USING abap_false.

image001

Thanks in advance!

Activity

  1. jmgrassau commented on Sep 25, 2024

    @jmgrassau
    Member

    Hi Raukze,

    please check in menu Help / About whether you are using the current release of ABAP cleaner (version 19.2) – I think this issue was already resolved.

    Kind regards,
    Jörg-Michael

  2. jmgrassau commented on Sep 25, 2024

    @jmgrassau
    Member

    P.S.: No, wait, now I can reproduce it! Okay, that's a bug, of course.

  3. self-assigned this
    on Sep 28, 2024
  4. jmgrassau commented on Sep 28, 2024

    @jmgrassau
    Member

    Hi Raukze,

    this bug should be fixed with the next release. Comment lines after the colon or comma will now be moved above the unchained commands, assuming that they comment on the respective part of the chain:

    image

    Kind regards,
    Jörg-Michael

  5. jmgrassau commented on Sep 30, 2024

    @jmgrassau
    Member

    Hi Raukze,

    thanks again for reporting this issue! I meanwhile enhanced the "stress test" (which systematically introduces comments, pragmas and colons into the ABAP cleaner test code and checks whether the cleanup rules can deal with them) and found two more cleanup rules in which this issue could have come up. All should now be fixed in version 1.19.3, which was just released!

    Kind regards,
    Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions