Skip to content

Replace obsolete MOVE for chained fields #32

Closed

Description

@jelliottp

Replacing the obsolete MOVE command is a great rule! However it does not seem to work for multiple chained fields.

Before

MOVE:
  source1 TO destination1,
  source2 TO destination2.

After

destination1 = source1.
destination2 = source2.

Activity

  1. ConjuringCoffee commented on May 26, 2023

    @ConjuringCoffee
    Contributor

    It works correctly if the rule "Unchain into multiple statements" is active too:

    image

  2. jmgrassau commented on May 26, 2023

    @jmgrassau
    Member

    Hi Josh,

    yes, those chain colons are a bit of a pain, because you could have them in any place, making cleanup rules' lives more difficult! E.g., you might have

      ADD 1 TO: lv_any, 
                lv_other.

    But I admit that MOVE: could be a particularly common finding, so I guess it is worth enhancing the "Replace obsolete MOVE …" rule accordingly (even if the "Unchain" rule is deactivated).

    Kind regards,
    Jörg-Michael

  3. jelliottp commented on May 26, 2023

    @jelliottp
    Author

    It works correctly if the rule "Unchain into multiple statements" is active too:

    image

    Interesting, I am using that rule and that wasn't my experience. However I looked and this particular setting was not on:
    image

    Once that is enabled it does work. Even with that said, because this is an obsolete statement I think the default behavior of the "Replace obsolete MOVE …" rule should also handle this.

  4. self-assigned this
    on Jun 6, 2023
  5. jmgrassau commented on Jun 6, 2023

    @jmgrassau
    Member

    Hi Josh,

    this new option is now available with version 1.3.0!

    image

    So MOVE: chains can now be replaced even if "Unchain into multiple statements" is deactivated.

    Kind regards,
    Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions