Skip to content

Number of lines in "Highlight inner space changes" not always correct? #25

Closed

Description

@ConjuringCoffee

In the following example, the number of lines for "Highlight inner space changes" is 0, but I'd have expected it to be 1.

image

If I uncheck the rule for removing lang="en", then the line number is increased to 1.

image

Is this a bug or this behavior intended?

Activity

  1. jmgrassau commented on May 25, 2023

    @jmgrassau
    Member

    Hi ConjuringCoffee,

    wow, that's well observed… will look into it, my first impression is that this part of the code anyway needs to be reworked a bit. And yes, I can't claim that showing "0 lines" here is an intended feature :-), especially since activating and deactivating the "Highlight inner space changes" option actually changes the orange highlight of the spaces in the right-hand display.

    Kind regards,
    Jörg-Michael

  2. jmgrassau commented on May 25, 2023

    @jmgrassau
    Member

    Hi ConjuringCoffee,

    okay, this refactoring has the nice additional effect that you will now be able to deactivate even the last option, now called "Highlight text and line changes" (for text changes and added/deleted lines):

    image

    This allows to completely turn off the highlighting and get an overall impression of what the cleaned code looks like.

    The above bug should also be fixed now (i.e. in the next release).

    Kind regards,
    Jörg-Michael

  3. ConjuringCoffee commented on May 25, 2023

    @ConjuringCoffee
    ContributorAuthor

    Hi Jörg-Michael, that was fast - thanks!

  4. self-assigned this
    on May 25, 2023
  5. jmgrassau commented on May 25, 2023

    @jmgrassau
    Member

    Hi ConjuringCoffee,

    hope this is now resolved in the new release (version 1.2.1), otherwise please let me know!

    Kind regards,
    Jörg-Michael

  6. ConjuringCoffee commented on May 26, 2023

    @ConjuringCoffee
    ContributorAuthor

    I can confirm that it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions