You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Number of lines in "Highlight inner space changes" not always correct? #25
wow, that's well observed… will look into it, my first impression is that this part of the code anyway needs to be reworked a bit. And yes, I can't claim that showing "0 lines" here is an intended feature :-), especially since activating and deactivating the "Highlight inner space changes" option actually changes the orange highlight of the spaces in the right-hand display.
okay, this refactoring has the nice additional effect that you will now be able to deactivate even the last option, now called "Highlight text and line changes" (for text changes and added/deleted lines):
This allows to completely turn off the highlighting and get an overall impression of what the cleaned code looks like.
The above bug should also be fixed now (i.e. in the next release).
Activity
jmgrassau commentedon May 25, 2023
Hi ConjuringCoffee,
wow, that's well observed… will look into it, my first impression is that this part of the code anyway needs to be reworked a bit. And yes, I can't claim that showing "0 lines" here is an intended feature :-), especially since activating and deactivating the "Highlight inner space changes" option actually changes the orange highlight of the spaces in the right-hand display.
Kind regards,
Jörg-Michael
jmgrassau commentedon May 25, 2023
Hi ConjuringCoffee,
okay, this refactoring has the nice additional effect that you will now be able to deactivate even the last option, now called "Highlight text and line changes" (for text changes and added/deleted lines):
This allows to completely turn off the highlighting and get an overall impression of what the cleaned code looks like.
The above bug should also be fixed now (i.e. in the next release).
Kind regards,
Jörg-Michael
ConjuringCoffee commentedon May 25, 2023
Hi Jörg-Michael, that was fast - thanks!
allow deactivation of 'Highlight text and line changes' option (SAP#25)
allow deactivation of 'Highlight text and line changes' option (#25)
jmgrassau commentedon May 25, 2023
Hi ConjuringCoffee,
hope this is now resolved in the new release (version 1.2.1), otherwise please let me know!
Kind regards,
Jörg-Michael
ConjuringCoffee commentedon May 26, 2023
I can confirm that it works now.