Skip to content

##Needed is not correct recognized #200

Closed

Description

@fmabap

Hi,
in the following example is ##NEEDED not at the end of the variable declaration.
ABAP-Cleaner set it to the end, but then it does not recognize that it is there and creates a TODO.
Can you please fix it?

image
 METHOD test.

    ##NEEDED data lv_msg type bapi_msg.

    DATA: lv_field TYPE c,
          ##NEEDED lv_msg2 type bapi_msg.

    MESSAGE e001(000) INTO lv_msg.
    MESSAGE e001(000) INTO lv_msg2.

    lv_field = 3.
    WRITE lv_field.
  ENDMETHOD.

Best regards
Frank

Activity

  1. self-assigned this
    on Nov 16, 2023
  2. jmgrassau commented on Nov 16, 2023

    @jmgrassau
    Member

    Hi Frank,

    you're right, thanks for reporting this! Indeed, this rule so far only considered pragmas at the end (before the comma or period), not at the beginning of the line, although those are correct, too. This will be fixed with the next release!

    Kind regards,
    Jörg-Michael

  3. fmabap commented on Nov 16, 2023

    @fmabap
    Author

    Hi Jörg-Michael,
    great thank you!

    Best regards
    Frank

  4. jmgrassau commented on Nov 16, 2023

    @jmgrassau
    Member

    Hi Frank,

    thanks again for opening this issue – this is now fixed with version 1.11.2, which was just released!

    Kind regards,
    Jörg-Michael

  5. jmgrassau commented on Feb 12, 2024

    @jmgrassau
    Member

    Hi,

    sorry, I entered the wrong issue number in the above commit enable ABAP cleaner menus for WebDynpro implementations – this belongs to issue #220!

    Kind regards,
    Jörg-Michael

  6. fmabap commented on Feb 12, 2024

    @fmabap
    Author

    Hi Jörg-Michael,

    no problem. Thank you for fixing it. It works in my Testprogramm and also in the productive code.

    Kind regards
    Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions