Skip to content

CANCEL-button placement inconsistent #188

Closed

Description

@VladGhitulescu

Hey,

the CANCEL-button is placed both on the left and right side (see the attached screenshots) which leads to accidental clicks on the wrong button.

CleanShot 2023-11-09 at 05 50 55@2x

CleanShot 2023-11-09 at 05 51 39@2x

On the Mac the default position for CANCEL is on the left (see again the attached screenshots).

CleanShot 2023-11-09 at 05 53 35@2x
CleanShot 2023-11-09 at 05 53 05@2x

Regards,
Vlad

Activity

  1. jmgrassau commented on Nov 9, 2023

    @jmgrassau
    Member

    Hi Vlad,

    ah, good point! Of course this should be consistent at least within ABAP cleaner. Not sure about the best order, though, for example MS Word (on Windows) would give me:

    image

    But since we are an ADT / Eclipse plug-in, I guess adjusting to ADT standards would be the best way to go. E.g., if I close an editor with an unsaved change, I get:

    image

    Menu "Window / Preferences" shows:

    image

    A wizard like "File / New / ABAP Project" has:

    image

    Do you get the same on macOS or is that OS-specific?

    Kind regards,
    Jörg-Michael

  2. VladGhitulescu commented on Nov 9, 2023

    @VladGhitulescu
    Author

    Hello again JM,

    Eclipse aligns with the OS guidelines:

    CleanShot 2023-11-09 at 09 27 12

    Regards,
    Vlad

  3. self-assigned this
    on Jan 1, 2024
  4. jmgrassau commented on Jan 1, 2024

    @jmgrassau
    Member

    Hi Vlad,

    thanks again for opening this issue! With the next release, the order of OK / Cancel buttons should be in line with the respective OS standards, i.e. "OK – Cancel" for Windows, but "Cancel – OK" for macOS and Linux.

    Kind regards,
    Jörg-Michael

  5. jmgrassau commented on Jan 5, 2024

    @jmgrassau
    Member

    Hi Vlad,

    thanks again for taking such a close look at these buttons and their order – this should now be fixed with version 1.13.0, which was just released!

    Kind regards,
    Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions