You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Display issues in Dark theme after changing option of rule Standardize CLASS ... DEFINITION #179
When the Dark theme is active, changing any option of rule Standardize CLASS ... DEFINITION leads to the background of the options being set to the same color as the text and thus the text is no longer readable.
The issue can be resolved by reopening the rule.
changed the title [-]Display issues after changing option of rule `Standardize CLASS ... DEFINITION`[/-][+]Display issues in `Dark theme` after changing option of rule `Standardize CLASS ... DEFINITION`[/+]on Oct 31, 2023
this issue is really haunting me, or to quote Mark Twain (sort of): "This problem is easy to resolve, I have myself done it a hundred times…"
But it will be fixed with the next release. The issue was that the label "For multi-liners …" (a control that is never used in the other rules) caused a layout event before the background color could correctly be retrieved; then the default (i.e. light theme) background color was returned by the control, and when the options were changed, setBackground() caused the light theme background to be shown.
Activity
[-]Display issues after changing option of rule `Standardize CLASS ... DEFINITION`[/-][+]Display issues in `Dark theme` after changing option of rule `Standardize CLASS ... DEFINITION`[/+]jmgrassau commentedon Oct 31, 2023
Hi Benedikt,
this issue is really haunting me, or to quote Mark Twain (sort of): "This problem is easy to resolve, I have myself done it a hundred times…"
But it will be fixed with the next release. The issue was that the label "For multi-liners …" (a control that is never used in the other rules) caused a layout event before the background color could correctly be retrieved; then the default (i.e. light theme) background color was returned by the control, and when the options were changed, setBackground() caused the light theme background to be shown.
Kind regards,
Jörg-Michael
bnichell commentedon Oct 31, 2023
Hi Jörg-Michael,
supporting multi themes is always a pain, tell me about it... Thanks for the quick fix.
Cheers,
Benedikt
fix ClassDefinitionRule for dark theme (SAP#179)
fix ClassDefinitionRule for dark theme (#179)
jmgrassau commentedon Nov 1, 2023
Hi Benedikt,
thanks again for reporting this bug – it should be fixed (and hopefully never come up again!) in version 1.10.0, which was just released!
Kind regards,
Jörg-Michael