Skip to content

Display issues in Dark theme after changing option of rule Standardize CLASS ... DEFINITION #179

Closed

Description

@bnichell

When the Dark theme is active, changing any option of rule Standardize CLASS ... DEFINITION leads to the background of the options being set to the same color as the text and thus the text is no longer readable.
The issue can be resolved by reopening the rule.

Other themes are not affected.

Before changing any option:
image

After changing any option:
image

Activity

  1. changed the title [-]Display issues after changing option of rule `Standardize CLASS ... DEFINITION`[/-] [+]Display issues in `Dark theme` after changing option of rule `Standardize CLASS ... DEFINITION`[/+] on Oct 31, 2023
  2. self-assigned this
    on Oct 31, 2023
  3. jmgrassau commented on Oct 31, 2023

    @jmgrassau
    Member

    Hi Benedikt,

    this issue is really haunting me, or to quote Mark Twain (sort of): "This problem is easy to resolve, I have myself done it a hundred times…"

    But it will be fixed with the next release. The issue was that the label "For multi-liners …" (a control that is never used in the other rules) caused a layout event before the background color could correctly be retrieved; then the default (i.e. light theme) background color was returned by the control, and when the options were changed, setBackground() caused the light theme background to be shown.

    Kind regards,
    Jörg-Michael

  4. bnichell commented on Oct 31, 2023

    @bnichell
    Author

    Hi Jörg-Michael,

    supporting multi themes is always a pain, tell me about it... Thanks for the quick fix.

    Cheers,
    Benedikt

  5. jmgrassau commented on Nov 1, 2023

    @jmgrassau
    Member

    Hi Benedikt,

    thanks again for reporting this bug – it should be fixed (and hopefully never come up again!) in version 1.10.0, which was just released!

    Kind regards,
    Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions