You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug/Request: Single line alignment of VALUE Expressions with BASE/FOR #170
in an an earlier version - I think before 1.8.0 - small short VALUE expressions that used BASE or FOR were usually kept in one line. Now they are always put into 2 lines.
If this change is because of some clean code rule, I would like the option that such short assignment are kept in one line.
If it's a bug, then please fix it.
changed the title [-]Bug/Request: Alignment of VALUE Expressions with BASE/FOR[/-][+]Bug/Request: Single line alignment of VALUE Expressions with BASE/FOR[/+]on Oct 27, 2023
you're right, this was previously kept on one line, but unintentionally (see #154): the option "Table rows: Keep multiple components on single line" did more than it was meant to do. But I do see your point – maybe we just need a dedicated option for these cases…
with the next release, you will find the following new option in the rule "Align parameters and components":
For "Never", you get:
For "Always" or "If maximum line length A is observed", the code on the left-hand side is preserved. This is then similar to the behavior before version 1.8.0, but a bit stricter, requiring line length A (default: 120 chars) to be observed instead of line length B (default: 160 chars).
Activity
[-]Alignement of VALUE Expressions with BASE[/-][+]Alignement of VALUE Expressions with BASE/FOR[/+][-]Alignement of VALUE Expressions with BASE/FOR[/-][+]Bug/Request: Alignment of VALUE Expressions with BASE/FOR[/+][-]Bug/Request: Alignment of VALUE Expressions with BASE/FOR[/-][+]Bug/Request: Single line alignment of VALUE Expressions with BASE/FOR[/+]jmgrassau commentedon Oct 28, 2023
Hi Ludwig,
you're right, this was previously kept on one line, but unintentionally (see #154): the option "Table rows: Keep multiple components on single line" did more than it was meant to do. But I do see your point – maybe we just need a dedicated option for these cases…
Kind regards,
Jörg-Michael
stockbal commentedon Oct 30, 2023
Hi Jörg-Michael,
a new option sounds good 😊.
Kind regards,
Ludwig
jmgrassau commentedon Jan 1, 2024
Hi Ludwig,
with the next release, you will find the following new option in the rule "Align parameters and components":
For "Never", you get:
For "Always" or "If maximum line length A is observed", the code on the left-hand side is preserved. This is then similar to the behavior before version 1.8.0, but a bit stricter, requiring line length A (default: 120 chars) to be observed instead of line length B (default: 160 chars).
Kind regards,
Jörg-Michael
stockbal commentedon Jan 1, 2024
Hi Jörg-Michael,
thanks a lot 😊👍🏻.
Kind regards,
Ludwig
enhance AlignParametersRule with option 'Keep other one-liners' (SAP#170
enhance AlignParametersRule with option 'Keep other one-liners' (#170)
jmgrassau commentedon Jan 5, 2024
Hi Ludwig,
thanks for opening this issue – the new option is now available with version 1.13.0, which was just released!
Kind regards,
Jörg-Michael