You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bad result of Align SORT command ( stand alone cleaner in WINDOWS) #141
I now enhanced this cleanup rule to consider SORT: chains as well:
Note that still only the component lists are aligned, keeping the BY keywords where they are – aligned or unaligned – because with the additions STABLE, ASCENDING/DESCENDING, AS TEXT after the table name, aligning "BY" might create huge gaps:
To align everything, we'd need more options to configure what that should look like.
Kind regards,
Jörg-Michael
Reacted by Thomas Madsen Nielsen and ConjuringCoffee
Activity
jmgrassau commentedon Oct 12, 2023
Hi Thomas,
thanks a lot for this example! You're right, of course – I shall look into this! I guess the expected result would be
so all components are aligned, even if the table names have different length.
Kind regards,
Jörg-Michael
TMNielsenApS commentedon Oct 12, 2023
Hi Jörg-Michael
Yes that would be the result I prefere, but I am no clean-code expert.
I think maybe other people would prefere this result:
Regards Thomas
TMNielsenApS commentedon Oct 12, 2023
naa - I ment this result:
jmgrassau commentedon Oct 16, 2023
Hi Thomas,
I now enhanced this cleanup rule to consider SORT: chains as well:
Note that still only the component lists are aligned, keeping the BY keywords where they are – aligned or unaligned – because with the additions STABLE, ASCENDING/DESCENDING, AS TEXT after the table name, aligning "BY" might create huge gaps:
To align everything, we'd need more options to configure what that should look like.
Kind regards,
Jörg-Michael
fix AlignClearFreeAndSortRule for SORT: chains (SAP#141)
fix AlignClearFreeAndSortRule for SORT: chains (#141)
jmgrassau commentedon Oct 16, 2023
Hi Thomas,
thanks again for reporting this bug – this should now be fixed in version 1.7.2, which was just released.
Kind regards,
Jörg-Michael