Skip to content

Converting CHECK outside loop to IF NOT ... RETURN considering BREAK-POINT #135

Closed

Description

@blackfish5

Could BREAK-POINT statement be considered the same way as local declarations at the beginning of the method so that CHECK in the following code is NOT converted to IF ... RETURN ... ENDIF?

METHOD process.
  DATA a TYPE c LENGTH 1.
  BREAK-POINT ID fins_rev_rec_acdocp.
  CHECK a IS INITIAL.
ENDMETHOD.

Activity

  1. self-assigned this
    on Oct 10, 2023
  2. jmgrassau commented on Oct 10, 2023

    @jmgrassau
    Member

    Hi blackfish5,

    that's a good point, thanks for bringing this up! And I think this is valid for all Checkpoints (ASSERT, BREAK-POINT, LOG-POINT). However, rather than considering them like local declarations, I think it would be better to add an option like "[X] Keep CHECK statement independent of previous ASSERT, BREAK-POINT, or LOG-POINT".

    Kind regards,
    Jörg-Michael

  3. jmgrassau commented on Oct 10, 2023

    @jmgrassau
    Member

    Hi blackfish5,

    the new option is now available with version 1.7.0, which was just released! My initial wording was a bit complicated, hope this works better:

    image

    Kind regards,
    Jörg-Michael

  4. blackfish5 commented on Oct 11, 2023

    @blackfish5
    Author

    I have updated to 1.7.1 and it works as expected. Thanks a lot for swift implementation.

    BR
    Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions