You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Docs enhancement: Guide to use ABAP Cleaner in Github Workflow #127
I now got a first working version of a Github Action Workflow that uses ABAP Cleaner 😄.
As I am not a GitHub Workflow expert by far, I am not sure if it is the best approach to do it, but hey, it is working.
Here is the workflow in my sample repository. I only had one minor hickup after the job first ran and I tried to import the changes back into my ABAP system.
After a little bit of debugging I found the culprit... crlf 😋. abapGit is splitting the received text content from git at lf into an internal table. The left behind carriage return is then seen as unknown statement and the import fails.
In a local setup the crlf characters written by ABAP cleaner never caused this because of the git setting core.autocrlf = true. And luckily enough this can also be set inside the workflow. So an additional step before the checkout solved it.
that's amazing!! Hardly any GitHub Workflow knowledge on my side, but could you try changing the hard-coded release number into this: releases/download/v1.6.0/ -> releases/latest/download/
the How to use ABAP cleaner documentation was now enhanced with a section on GitHub Actions workflow usage! Hope this is as you expected it to be – otherwise please let me know. And again thanks so much for you contributions!
Activity
jmgrassau commentedon Oct 2, 2023
Hi Ludwig,
that's amazing!! Hardly any GitHub Workflow knowledge on my side, but could you try changing the hard-coded release number into this:
releases/download/v1.6.0/->releases/latest/download/https://github.com/SAP/abap-cleaner/releases/latest/download/com.sap.adt.abapcleaner.app-linux.gtk.x86_64.tar.gz
Oops 😉 Yes, the world would be a better place without / versus \ or
crlfversuslf…Kind regards,
Jörg-Michael
stockbal commentedon Oct 2, 2023
Hi Jörg-Michael,
Ah, I knew there was a way to get the latest release 👍🚀 . Change is done, works like a charm.
Kind regards,
Ludwig
add example of GitHub Actions workflow usage (SAP#127)
add example of GitHub Actions workflow usage (#127)
jmgrassau commentedon Oct 10, 2023
Hi Ludwig,
the How to use ABAP cleaner documentation was now enhanced with a section on GitHub Actions workflow usage! Hope this is as you expected it to be – otherwise please let me know. And again thanks so much for you contributions!
Kind regards,
Jörg-Michael