feat: Hide Others section (watch order, op/ed, news) on anime details…#351
feat: Hide Others section (watch order, op/ed, news) on anime details…#351RyanYuuki merged 5 commits intoRyanYuuki:mainfrom
Conversation
… when service is Simkl
There was a problem hiding this comment.
Pull request overview
This PR updates the anime details UI to hide the “Others” section (watch order, OP/ED, news) when the current media/service is Simkl, aligning the details page content with what Simkl supports.
Changes:
- Add a
serviceTypeparameter toAnimeStatsso it can conditionally render the “Others” section. - Pass
widget.media.serviceTypefromAnimeDetailsPageintoAnimeStats. - Gate rendering of
_buildOthersSectionand its spacing whenserviceType == ServicesType.simkl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/screens/anime/widgets/anime_stats.dart | Adds service-type-based conditional rendering to hide the “Others” section for Simkl. |
| lib/screens/anime/details_page.dart | Passes the media’s serviceType into AnimeStats to drive the new conditional behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if (serviceType != null && | ||
| (serviceType != ServicesType.simkl)) | ||
| _buildOthersSection(context), | ||
| if (serviceType != null && | ||
| (serviceType != ServicesType.simkl)) | ||
| const SizedBox(height: 16), |
There was a problem hiding this comment.
AnimeStats already has data: Media, and Media.serviceType is non-null/required. Adding a separate nullable serviceType prop creates a second source of truth and the repeated if (serviceType != null && serviceType != ServicesType.simkl) blocks duplicate logic. Consider using data.serviceType (or the existing local isSimkl) and collapsing this into a single conditional block (e.g., a single if with a spread list) so the section behavior stays consistent and null defaults don’t accidentally hide the section in other call sites.
|
Reduce the spacing while you're at it |
|
can you do one more thing? like change recommended animes to shows/movies based on type |
make vertical spacers conditional per section
…pe and media type
|
@itsmechinmoy done @RyanYuuki |
… when service is Simkl
Before