Conversation
…s to check the tests for correctness while not interfering with/overshadowing the desired cyrxnopt package import in test files
…I to control versions
…or individually run tests
dulithaprasanna
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The function signatures and config interfaces drifted over time and are no longer matching as they need to between optimizer class implementations. This PR adds mypy and testing to enforce checks for these things and ensure that they cannot drift again for the implemented optimizer classes. With the addition of mypy, more type annotations were also added to help make the interfaces clearer.
Related Issues/Pull Requests
As part of the basic tests I added to the optimizers, they are run against a simple objective function (although answers are not checked). I think that this satisfies and closes #23. In the same vein, I think it closes #4.
Todos