Presentable allowStepWhenDismissed is ignored and overridden with parent flow
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overridden by parent flow
|
@twittemb would be very nice, if you find some time to have a look |
|
@mgray88 is there chance that you can help me instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, I noticed that presentables (not flows) utilises parent flow
allowStepWhenDismissedinstead of its own property.It may lead to a scenario where stepper and presentable are unexpectedly held in the memory until the parent flow is released.
I doubt if it is an intended behaviour.
The PR fixes it.
Checklist