Skip to content

fix(release): repair stale workflow references - #38

Merged
Rwanbt merged 2 commits into
devfrom
fix/publish-dead-workflow-ref
Aug 12, 2026
Merged

fix(release): repair stale workflow references#38
Rwanbt merged 2 commits into
devfrom
fix/publish-dead-workflow-ref

Conversation

@Rwanbt

@Rwanbt Rwanbt commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Issue for this PR

Closes #30

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Repairs seven stale references to fork-release.yml after the workflow was renamed to release.yml. This restores the French README badge and the publish error guidance while preserving the dated historical references that intentionally document the rename. The PR also makes the tab-close E2E deterministic by selecting the requested package.json result instead of the first file result.

How did you verify your code works?

Typecheck passed for all 35 packages on push. The targeted tab-close E2E test passed locally (1/1), and GitHub checks on the previous run passed; checks are rerunning for this update.

Screenshots / recordings

Not a UI change; no screenshot required.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

The release workflow was renamed from `fork-release.yml` to `release.yml` on
2026-08-10 — release.yml documents the rename in its own header — but only one
side of the rename was done. Seven references were left pointing at a file that
no longer exists.

Two of them are not just stale prose:

- README.fr.md linked its build-status badge to `fork-release.yml`, so the
  French README showed a broken badge while README.md, already updated, showed
  a working one.
- script/publish.ts names the workflow in the error it throws at anyone running
  upstream's publish path, so the message directed the reader to a file that is
  not there.

The rest are comments in install, beta.yml, bundle-mobile.mjs,
desktop/scripts/utils.ts and unifia/src/installation/index.ts.

Two mentions are deliberately kept: release.yml's own header, which explains the
rename, and docs/autonomy/reports/REBRAND-E9-E12-2026-08-09.md, a dated report
describing the repository as it stood on 2026-08-09. Rewriting the latter would
falsify a record.

Evidence: typecheck 35/35, run after clearing every node_modules/.ts-dist.
@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot closed this Aug 12, 2026
@Rwanbt Rwanbt reopened this Aug 12, 2026
@Rwanbt
Rwanbt merged commit 9c645dc into dev Aug 12, 2026
29 checks passed
@Rwanbt
Rwanbt deleted the fix/publish-dead-workflow-ref branch August 12, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant